You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/01/14 03:37:17 UTC
[GitHub] [incubator-apisix-dashboard] lilien1010 opened a new pull request
#118: Upstream support websocket enable and hashOn select
lilien1010 opened a new pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366242791
##########
File path: src/lang/zh.ts
##########
@@ -83,5 +83,12 @@ export default {
inputMultipleValues: '输入值后并回车',
propertyHostsTip: '任何值均可'
}
+ },
+ upstream: {
+ websocket: {
+ EnabledTips: 'WebSocket 打开',
+ DisabledTips: 'WebSocket 关闭'
+ },
+ keyTips: '你可以编辑并输入任何值,输入值后 回车确认。'
Review comment:
任何值，输
输入值后回车确认。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] lilien1010 commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366285269
##########
File path: src/views/schema/upstream/edit.vue
##########
@@ -348,6 +410,13 @@ export default class extends Vue {
.el-input {
width: 193px;
}
+ .tip {
+ line-height: 24px;
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] lilien1010 commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366280344
##########
File path: src/views/schema/routes/edit.vue
##########
@@ -383,6 +383,7 @@ export default class extends Vue {
}
})
+ delete data['tempPlugin']
Review comment:
temp['tempPlugin']==null will not enter the delete logic so I think we can keep it this way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] lilien1010 commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366281356
##########
File path: src/views/schema/upstream/edit.vue
##########
@@ -53,6 +53,26 @@
</el-select>
</el-form-item>
+ <el-form-item
+ label="Hash On"
+ >
+ <el-select
+ v-model="form.hash_on"
+ placeholder="Select a hash on"
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366242434
##########
File path: src/lang/en.ts
##########
@@ -75,5 +75,12 @@ export default {
inputMultipleValues: 'Input value then press return button',
propertyHostsTip: 'Any values are supported'
}
+ },
+ upstream: {
+ websocket: {
+ EnabledTips: 'WebSocket enabled',
+ DisabledTips: 'WebSocket disabled'
+ },
+ keyTips: 'You can edit and input any value here,press Enter to confirm.'
Review comment:
here, and press
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366243417
##########
File path: src/views/schema/routes/edit.vue
##########
@@ -383,6 +383,7 @@ export default class extends Vue {
}
})
+ delete data['tempPlugin']
Review comment:
if (temp['tempPlugin']) {}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366249521
##########
File path: src/views/schema/upstream/edit.vue
##########
@@ -348,6 +410,13 @@ export default class extends Vue {
.el-input {
width: 193px;
}
+ .tip {
+ line-height: 24px;
Review comment:
2 spaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] lilien1010 commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
lilien1010 commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366271461
##########
File path: src/lang/en.ts
##########
@@ -75,5 +75,12 @@ export default {
inputMultipleValues: 'Input value then press return button',
propertyHostsTip: 'Any values are supported'
}
+ },
+ upstream: {
+ websocket: {
+ EnabledTips: 'WebSocket enabled',
+ DisabledTips: 'WebSocket disabled'
+ },
+ keyTips: 'You can edit and input any value here,press Enter to confirm.'
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366249597
##########
File path: src/views/schema/upstream/edit.vue
##########
@@ -348,6 +410,13 @@ export default class extends Vue {
.el-input {
width: 193px;
}
+ .tip {
+ line-height: 24px;
+ font-size: 12px;
+ margin: 0;
+ color: #8e8c8c;
+ display:inline;
Review comment:
space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366244458
##########
File path: src/views/schema/upstream/edit.vue
##########
@@ -73,6 +93,23 @@
:value="item.value"
/>
</el-select>
+ <p class="tip">
+ {{ $t('upstream.keyTips') }}
+ </p>
+ </el-form-item>
+
+ <el-form-item
+ label="WebSocket"
+ >
+ <el-switch
+ v-model="form.enable_websocket"
+
+ active-color="#13ce66"
+ inactive-color="#ff4949"
+ />
+ <p class="tip">
+ {{ form.enable_websocket?$t('upstream.websocket.EnabledTips'):$t('upstream.websocket.DisabledTips') }}
Review comment:
space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366243618
##########
File path: src/views/schema/upstream/edit.vue
##########
@@ -53,6 +53,26 @@
</el-select>
</el-form-item>
+ <el-form-item
+ label="Hash On"
+ >
+ <el-select
+ v-model="form.hash_on"
+ placeholder="Select a hash on"
Review comment:
i18n
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366242275
##########
File path: src/lang/en.ts
##########
@@ -75,5 +75,12 @@ export default {
inputMultipleValues: 'Input value then press return button',
propertyHostsTip: 'Any values are supported'
}
+ },
+ upstream: {
+ websocket: {
+ EnabledTips: 'WebSocket enabled',
Review comment:
Please use tip instead of tips
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #118:
Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366249340
##########
File path: src/views/schema/upstream/edit.vue
##########
@@ -230,7 +288,9 @@ export default class extends Vue {
type = null,
nodes = [],
key = null,
- desc = ''
+ desc = '',
+ enable_websocket = null,
+ hash_on = null
Review comment:
Boolean type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on a change in
pull request #118: Upstream support websocket enable and hashOn select
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #118: Upstream support websocket enable and hashOn select
URL: https://github.com/apache/incubator-apisix-dashboard/pull/118#discussion_r366244230
##########
File path: src/views/schema/upstream/edit.vue
##########
@@ -73,6 +93,23 @@
:value="item.value"
/>
</el-select>
+ <p class="tip">
+ {{ $t('upstream.keyTips') }}
+ </p>
+ </el-form-item>
+
+ <el-form-item
+ label="WebSocket"
+ >
+ <el-switch
+ v-model="form.enable_websocket"
+
Review comment:
remove this space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services