You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/04 14:22:24 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #23592: Automatically register DAGs that are used in a context manager

potiuk commented on code in PR #23592:
URL: https://github.com/apache/airflow/pull/23592#discussion_r937851593


##########
airflow/models/dag.py:
##########
@@ -312,6 +316,7 @@ class DAG(LoggingMixin):
         ``Environment`` is used to render templates as string values.
     :param tags: List of tags to help filtering DAGs in the UI.
     :param schedule_on: List of upstream datasets if for use in triggering DAG runs.
+    :param auto_register: Automatically register this DAG when it is used in a ``with`` block

Review Comment:
   Yeah. I like it the way it is now. with X.with_something() does not look good, and the current way is more explicit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org