[GitHub] [mesos] asekretenko edited a comment on pull request #388: Fixed a bug where the cgroup task killer leaves the cgroup frozen.

[GitBox <gi...@apache.org>]

asekretenko edited a comment on pull request #388:
URL: https://github.com/apache/mesos/pull/388#issuecomment-850258298


   @cf-natali I'm trying to look into this and to make sure this is not making some other issues worse.
   
   For example, does this all mean that this deferred call that freezes a cgroup
   https://github.com/apache/mesos/blob/85981d7c728798783b2e1e7cbed4f27a1497ccb2/src/linux/cgroups.cpp#L1440
   
   has never been executed before this patch (due to immediate termination of a TaskKiller process), but, after this change, will be executing in some cases?...
   
   (Btw, inablilty to comment on an untouched line in a github PR is one of examples why, as of 2019-2020, Mesos committers were still preferring to review contribution using Apache Reviewboard. I'm not saying that we should not do something to simplify contributing via GitHub, just illustrating why the RB has not been phased out.)
   
   @ridv This, unfortunately, is not a "small patch", but an attempt to compensate for a deficiency in a workaround in a code that uses a rather problematic kernel interface and is already full of hacks and short-term solutions. I'm sorry, but reviewing such stuff meaningfully takes significant chunks of an uninterrupted time and should only be done in a very sound mind and a very good health (this was not my case in the beginnig of this week).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org