[GitHub] [incubator-training] MaineC commented on issue #45: Add draft github workshop slides

[GitBox <gi...@apache.org>]

MaineC commented on issue #45: Add draft github workshop slides
URL: https://github.com/apache/incubator-training/pull/45#issuecomment-534915708
 
 
   I tried it out on a Linux box. It was easy to build (didn't need to install any further dependencies, because Maven was already here), README correctly pointed me to the location of the generated slides.
   
   The current content is stored directly under GitHub. I think it would make sense to move it to a sub folder for the likely case that there will be non workshop material on Git/ GitHub.
   
   There seem to be some dependency notices missing in NOTICE (at least from judging what Maven downloads when I'm trying to build things)? Maybe though my understanding of what exactly goes into NOTICE is dated.
   
   From what I can see all headers are where they should be.
   
   For the octocat logo, I'll volunteer to generate one that's a little less stereotypical than the one I used in the original slides.
   
   Which tooling do you use to create these slides? Is there an easy way for me to help you? Content-wise there's still a lot of stuff that's text-only. But I guess that's the "work in progress" part of the pull request.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services