You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2009/04/20 08:11:47 UTC

[jira] Created: (HBASE-1330) binary keys broken on trunk

binary keys broken on trunk
---------------------------

                 Key: HBASE-1330
                 URL: https://issues.apache.org/jira/browse/HBASE-1330
             Project: Hadoop HBase
          Issue Type: Bug
    Affects Versions: 0.20.0
            Reporter: ryan rawson
             Fix For: 0.20.0
         Attachments: HBASE-1330.patch

The symptom is commits fail with 'table not found' exception - even though the table does in fact exist!

Digging in a little with debug logs indicate that getClosestRowBefore() is returning NULL, which for a table that exists should never be!  A key always falls into a region - either the first or the last one at the very least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1330) binary keys broken on trunk

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1330:
-------------------------------

    Status: Patch Available  (was: Open)

this is a typical META bug - using the normal Bytes comparator to compare the 'row' section causes problems when the first byte is '\0'.  So if you have keys that start with a value < ',', most common in the binary key case (when the first byte is '\0'), you end up with incorrect storing saying things like:

table,,1234  > table,\0,1234

which is not correct.  since [] < '\0'.


> binary keys broken on trunk
> ---------------------------
>
>                 Key: HBASE-1330
>                 URL: https://issues.apache.org/jira/browse/HBASE-1330
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1330.patch
>
>
> The symptom is commits fail with 'table not found' exception - even though the table does in fact exist!
> Digging in a little with debug logs indicate that getClosestRowBefore() is returning NULL, which for a table that exists should never be!  A key always falls into a region - either the first or the last one at the very least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1330) binary keys broken on trunk

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-1330:
-------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Thanks for fixing ugly issue Ryan.  Committed.

> binary keys broken on trunk
> ---------------------------
>
>                 Key: HBASE-1330
>                 URL: https://issues.apache.org/jira/browse/HBASE-1330
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1330.patch
>
>
> The symptom is commits fail with 'table not found' exception - even though the table does in fact exist!
> Digging in a little with debug logs indicate that getClosestRowBefore() is returning NULL, which for a table that exists should never be!  A key always falls into a region - either the first or the last one at the very least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1330) binary keys broken on trunk

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1330:
-------------------------------

    Attachment: HBASE-1330.patch

turns out the clone of a comparator loses the 'meta-ness' or 'root-ness'.  

> binary keys broken on trunk
> ---------------------------
>
>                 Key: HBASE-1330
>                 URL: https://issues.apache.org/jira/browse/HBASE-1330
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1330.patch
>
>
> The symptom is commits fail with 'table not found' exception - even though the table does in fact exist!
> Digging in a little with debug logs indicate that getClosestRowBefore() is returning NULL, which for a table that exists should never be!  A key always falls into a region - either the first or the last one at the very least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-1330) binary keys broken on trunk

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson reassigned HBASE-1330:
----------------------------------

    Assignee: ryan rawson

> binary keys broken on trunk
> ---------------------------
>
>                 Key: HBASE-1330
>                 URL: https://issues.apache.org/jira/browse/HBASE-1330
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1330.patch
>
>
> The symptom is commits fail with 'table not found' exception - even though the table does in fact exist!
> Digging in a little with debug logs indicate that getClosestRowBefore() is returning NULL, which for a table that exists should never be!  A key always falls into a region - either the first or the last one at the very least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1330) binary keys broken on trunk

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700678#action_12700678 ] 

stack commented on HBASE-1330:
------------------------------

+1 on commit after chatting with Ryan on the posted patch.

> binary keys broken on trunk
> ---------------------------
>
>                 Key: HBASE-1330
>                 URL: https://issues.apache.org/jira/browse/HBASE-1330
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1330.patch
>
>
> The symptom is commits fail with 'table not found' exception - even though the table does in fact exist!
> Digging in a little with debug logs indicate that getClosestRowBefore() is returning NULL, which for a table that exists should never be!  A key always falls into a region - either the first or the last one at the very least.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.