You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/18 05:30:32 UTC

[GitHub] [dubbo] zrlw removed a comment on pull request #9284: [3.0] set consumerUrl of instance URL at ServiceDiscoveryRegistryDirectory#notify to avoid NPE

zrlw removed a comment on pull request #9284:
URL: https://github.com/apache/dubbo/pull/9284#issuecomment-972545095


   there are many RpcContext.getServiceContext().getConsumerUrl().getXXX calls in InstanceAddressURL methods, it might cause problem because the lifecyle of InstanceAddressURL and RpcContext are different.
   when scope model is destroying, the thread local SERVICE_CONTEXT of RpcContext will be removed first, the InstanceAddressURL methods which use RpcContext.getServiceContext().getConsumerUrl() will throw NPE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org