You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by calavera <gi...@git.apache.org> on 2016/04/22 00:45:39 UTC

[GitHub] trafficserver pull request: Allow group and others to read from th...

GitHub user calavera opened a pull request:

    https://github.com/apache/trafficserver/pull/595

    Allow group and others to read from the log pipe.

    ASCII_PIPE logs are created with 0600 privileges.
    The owner of this pipe is `nobody` and the group is `nogroup`.
    This is very limiting and it makes impossible to use the pipe to read
    logs.
    
    Signed-off-by: David Calavera <da...@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/calavera/trafficserver fix_ascii_pipe_mode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/595.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #595
    
----
commit a84cefbe3f0129d461e43db3f7a3008a9066cae7
Author: David Calavera <da...@gmail.com>
Date:   2016-04-21T22:24:36Z

    Allow group and others to read from the log pipe.
    
    ASCII_PIPE logs are created with 0600 privileges.
    The owner of this pipe is `nobody` and the group is `nogroup`.
    This is very limiting and it makes impossible to use the pipe to read
    logs.
    
    Signed-off-by: David Calavera <da...@gmail.com>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: [TS-4383] Allow group and others to re...

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/595#issuecomment-215177002
  
    Do you build Traffic Server with ``--with-group=nogroup``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: [TS-4383] Allow group and others to re...

Posted by calavera <gi...@git.apache.org>.
Github user calavera commented on the pull request:

    https://github.com/apache/trafficserver/pull/595#issuecomment-215205582
  
    mmm, for some reason I thought it was the default, but yes, that's what we're using. If it's not the default, I agree that giving only access to the group is more reasonable. I made the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: [TS-4383] Allow group and others to re...

Posted by calavera <gi...@git.apache.org>.
Github user calavera commented on the pull request:

    https://github.com/apache/trafficserver/pull/595#issuecomment-215176514
  
    @jpeach nobody will be able to access it with only group either, because the group is `nogroup`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: [TS-4383] Allow group and others to re...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/trafficserver/pull/595


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request: [TS-4383] Allow group and others to re...

Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/595#issuecomment-215162624
  
    Group definitely seems reasonable. Let's not do other yet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---