You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/02 18:52:29 UTC

[GitHub] [kafka] cmccabe commented on a change in pull request #10366: KAFKA-12467: Add controller-side snapshot generation

cmccabe commented on a change in pull request #10366:
URL: https://github.com/apache/kafka/pull/10366#discussion_r606372293



##########
File path: metadata/src/main/java/org/apache/kafka/controller/ClientQuotaControlManager.java
##########
@@ -272,4 +276,44 @@ private ApiError validateEntity(ClientQuotaEntity entity, Map<String, String> va
 
         return ApiError.NONE;
     }
+
+    class ClientQuotaControlIterator implements Iterator<List<ApiMessageAndVersion>> {
+        private final long epoch;
+        private final Iterator<Entry<ClientQuotaEntity, TimelineHashMap<String, Double>>> iterator;
+
+        ClientQuotaControlIterator(long epoch) {
+            this.epoch = epoch;
+            this.iterator = clientQuotaData.entrySet(epoch).iterator();

Review comment:
       Yes, snapshots are consistent.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org