[jira] [Commented] (STORM-596) "topology.receiver.buffer.size" has no effect

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518020#comment-14518020 ] 

ASF GitHub Bot commented on STORM-596:
--------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/363#discussion_r29286966
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/worker.clj ---
    @@ -355,8 +355,7 @@
         (:storm-id worker)
         (:receiver-thread-count worker)
         (:port worker)
    -    (:transfer-local-fn worker)
    -    (-> worker :storm-conf (get TOPOLOGY-RECEIVER-BUFFER-SIZE))
    +    (:transfer-local-fn worker))
    --- End diff --
    
    There is an extra ')' here


> "topology.receiver.buffer.size"  has no effect
> ----------------------------------------------
>
>                 Key: STORM-596
>                 URL: https://issues.apache.org/jira/browse/STORM-596
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0, 0.9.3-rc2
>            Reporter: caofangkun
>            Assignee: caofangkun
>            Priority: Minor
>
> https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/messaging/loader.clj#L27
> backtype.storm.messaging.loader#mk-receive-thread  accepts max-buffer-size as an input but the value isn't used within the function.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)