[GitHub] spark pull request #21158: [SPARK-23850][sql] Add separate config for SQL op...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21158#discussion_r185142687
  
    --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -342,7 +342,7 @@ package object config {
             "a property key or value, the value is redacted from the environment UI and various logs " +
             "like YARN and event logs.")
           .regexConf
    -      .createWithDefault("(?i)secret|password|url|user|username".r)
    +      .createWithDefault("(?i)secret|password".r)
    --- End diff --
    
    Normally, making it stricter is not a big deal. However, if we want to relax it, this could be a big deal since users might expect these variables have been hided by default. cc the original reviewers and author @onursatici @ash211 @hvanhovell @jiangxb1987 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org