You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/04 10:19:49 UTC
[GitHub] [apisix] scaat opened a new pull request #1985: doc: add uri-blocker plugin Chinese docs
scaat opened a new pull request #1985:
URL: https://github.com/apache/apisix/pull/1985
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
add uri-blocker plugin Chinese docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #1985: doc: add uri-blocker plugin Chinese docs
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1985:
URL: https://github.com/apache/apisix/pull/1985#discussion_r465133081
##########
File path: doc/zh-cn/plugins/uri-blocker.md
##########
@@ -0,0 +1,92 @@
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+# 目录
Review comment:
need a link to the English version.
like: https://github.com/apache/apisix/pull/1985/files#diff-e8976e35ba880b8daf3c56fa658dd2b5R20
##########
File path: doc/zh-cn/plugins/uri-blocker.md
##########
@@ -0,0 +1,92 @@
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+# 目录
+
+- [**定义**](#定义)
+- [**属性列表**](#属性列表)
+- [**启用方式**](#启用方式)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+
+## 定义
+
+该插件可帮助我们拦截用户请求，只需要指定`block_rules`即可。
+
+## 属性列表
+
+|Name |Requirement |Description|
+|--------- |--------|-----------|
+|block_rules |必须|常规过滤规则数组。这些都是常规规则，如果当前请求 URI 命中任何一个，请将响应代码设置为rejected_code以退出当前用户请求。例如: `["root.exe", "root.m+"]`.|
Review comment:
`Regular filter rule array` -> 正则过滤数组
need a space between Chinese and English.
##########
File path: doc/zh-cn/plugins/uri-blocker.md
##########
@@ -0,0 +1,92 @@
+<!--
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+-->
+
+# 目录
+
+- [**定义**](#定义)
+- [**属性列表**](#属性列表)
+- [**启用方式**](#启用方式)
+- [**测试插件**](#测试插件)
+- [**禁用插件**](#禁用插件)
+
+## 定义
+
+该插件可帮助我们拦截用户请求，只需要指定`block_rules`即可。
+
+## 属性列表
+
+|Name |Requirement |Description|
+|--------- |--------|-----------|
+|block_rules |必须|常规过滤规则数组。这些都是常规规则，如果当前请求 URI 命中任何一个，请将响应代码设置为rejected_code以退出当前用户请求。例如: `["root.exe", "root.m+"]`.|
Review comment:
use Chinese `。` at the end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #1985: doc: add uri-blocker plugin Chinese docs
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1985:
URL: https://github.com/apache/apisix/pull/1985#issuecomment-668997819
@scaat many thx ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #1985: doc: add uri-blocker plugin Chinese docs
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1985:
URL: https://github.com/apache/apisix/pull/1985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org