You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/17 20:29:23 UTC
[GitHub] [airflow] fuxiao224 opened a new pull request, #23766: [Issue#22846] allow option to encode or not encode UUID when uploading from Cassandra to GCS
fuxiao224 opened a new pull request, #23766:
URL: https://github.com/apache/airflow/pull/23766
Issue#22846 -- allow option to encode or not encode UUID when uploading from Cassandra to GCS.
As discussed in issue [#22846](https://github.com/apache/airflow/issues/22846), a new parameter 'encode_uuid' is added to allow user to choose not to encode UUID, while ensures backward compatibility. However, some class methods becomes instance methods as they need to intake this instance parameter. Please feel free to make changes and let me know if you find any issues or concerns by making this change. Thanks!
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23766: [Issue#22846] allow option to encode or not encode UUID when uploading from Cassandra to GCS
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23766:
URL: https://github.com/apache/airflow/pull/23766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23766: [Issue#22846] allow option to encode or not encode UUID when uploading from Cassandra to GCS
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23766:
URL: https://github.com/apache/airflow/pull/23766#issuecomment-1132533652
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23766: [Issue#22846] allow option to encode or not encode UUID when uploading from Cassandra to GCS
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23766:
URL: https://github.com/apache/airflow/pull/23766#issuecomment-1131965699
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fuxiao224 commented on pull request #23766: [Issue#22846] allow option to encode or not encode UUID when uploading from Cassandra to GCS
Posted by GitBox <gi...@apache.org>.
fuxiao224 commented on PR #23766:
URL: https://github.com/apache/airflow/pull/23766#issuecomment-1132322124
Hi @potiuk ! Thanks for reviewing and approving this PR! Seems like it's ready to merge now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org