You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/06 10:16:49 UTC
[GitHub] [superset] dpgaspar commented on a diff in pull request #20567: feat(helm): add liveness and readiness for deployment webserver
dpgaspar commented on code in PR #20567:
URL: https://github.com/apache/superset/pull/20567#discussion_r914669399
##########
helm/superset/templates/deployment.yaml:
##########
@@ -117,6 +117,24 @@ spec:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
+ livenessProbe:
+ httpGet:
+ path: /health
+ port: http
+ initialDelaySeconds: {{ .Values.supersetNode.livenessProbe.initialDelaySeconds | default 15 }}
+ timeoutSeconds: {{ .Values.supersetNode.livenessProbe.timeoutSeconds | default 1 }}
+ failureThreshold: {{ .Values.supersetNode.livenessProbe.failureThreshold | default 3 }}
+ periodSeconds: {{ .Values.supersetNode.livenessProbe.periodSeconds | default 5 }}
+ successThreshold: {{ .Values.supersetNode.livenessProbe.successThreshold | default 1 }}
+ readinessProbe:
+ httpGet:
+ path: /health
+ port: http
+ initialDelaySeconds: {{ .supersetNode.Values.readinessProbe.initialDelaySeconds | default 15 }}
+ timeoutSeconds: {{ .Values.supersetNode.readinessProbe.timeoutSeconds | default 1 }}
+ failureThreshold: {{ .Values.supersetNode.readinessProbe.failureThreshold | default 3 }}
+ periodSeconds: {{ .Values.supersetNode.readinessProbe.periodSeconds | default 5 }}
+ successThreshold: {{ .Values.supersetNode.readinessProbe.successThreshold | default 1 }}
Review Comment:
I think it would be simpler to just set these values and not set a default here. I mean if we have a default it feels the default values should live on `values.yaml` instead of being "hardcoded" on the deployment template
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org