You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/01 08:58:35 UTC
[GitHub] [apisix-helm-chart] fengxsong opened a new pull request, #333: fix: incluster name resolve issue
fengxsong opened a new pull request, #333:
URL: https://github.com/apache/apisix-helm-chart/pull/333
Signed-off-by: fengxsong <fe...@outlook.com>
When nginx listen with hostnetwork, change default `dnsPolicy` to `ClusterFirstWithHostNet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] fengxsong commented on a diff in pull request #333: fix: incluster name resolve issue
Posted by GitBox <gi...@apache.org>.
fengxsong commented on code in PR #333:
URL: https://github.com/apache/apisix-helm-chart/pull/333#discussion_r960687772
##########
charts/apisix/templates/_helpers.tpl:
##########
@@ -96,17 +96,3 @@ prometheus:
{{- define "apisix.pluginAttrs" -}}
{{- merge .Values.pluginAttrs (include "apisix.basePluginAttrs" . | fromYaml) | toYaml -}}
{{- end -}}
-
-{{- define "apisix.podAntiAffinity" -}}
Review Comment:
not need for this template function. as kube-scheduler will take care of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #333: fix: incluster name resolve issue
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #333:
URL: https://github.com/apache/apisix-helm-chart/pull/333#discussion_r960495377
##########
charts/apisix/templates/_pod.tpl:
##########
@@ -115,6 +115,10 @@ spec:
{{- end }}
resources:
{{- toYaml .Values.apisix.resources | nindent 8 }}
+ {{- if .Values.apisix.hostNetwork }}
Review Comment:
Also add this field to readme.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] fengxsong commented on a diff in pull request #333: fix: incluster name resolve issue
Posted by GitBox <gi...@apache.org>.
fengxsong commented on code in PR #333:
URL: https://github.com/apache/apisix-helm-chart/pull/333#discussion_r960619498
##########
charts/apisix/templates/_pod.tpl:
##########
@@ -115,6 +115,10 @@ spec:
{{- end }}
resources:
{{- toYaml .Values.apisix.resources | nindent 8 }}
+ {{- if .Values.apisix.hostNetwork }}
Review Comment:
done, maybe we can use tools like https://github.com/norwoodj/helm-docs to generate README later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #333: fix: incluster name resolve issue
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #333:
URL: https://github.com/apache/apisix-helm-chart/pull/333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #333: fix: incluster name resolve issue
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #333:
URL: https://github.com/apache/apisix-helm-chart/pull/333#discussion_r960682167
##########
charts/apisix/templates/_pod.tpl:
##########
@@ -115,6 +115,10 @@ spec:
{{- end }}
resources:
{{- toYaml .Values.apisix.resources | nindent 8 }}
+ {{- if .Values.apisix.hostNetwork }}
Review Comment:
Yes, I agree! Helm-docs is a good tool
##########
charts/apisix/templates/_helpers.tpl:
##########
@@ -96,17 +96,3 @@ prometheus:
{{- define "apisix.pluginAttrs" -}}
{{- merge .Values.pluginAttrs (include "apisix.basePluginAttrs" . | fromYaml) | toYaml -}}
{{- end -}}
-
-{{- define "apisix.podAntiAffinity" -}}
Review Comment:
Why delete this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #333: fix: incluster name resolve issue
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #333:
URL: https://github.com/apache/apisix-helm-chart/pull/333#discussion_r991762634
##########
charts/apisix/templates/_helpers.tpl:
##########
@@ -96,17 +96,3 @@ prometheus:
{{- define "apisix.pluginAttrs" -}}
{{- merge .Values.pluginAttrs (include "apisix.basePluginAttrs" . | fromYaml) | toYaml -}}
{{- end -}}
-
-{{- define "apisix.podAntiAffinity" -}}
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org