You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/12 00:55:09 UTC

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #16464: [improve][broker][PIP-149]Make TruncateTopic pure async

mattisonchao commented on code in PR #16464:
URL: https://github.com/apache/pulsar/pull/16464#discussion_r918456052


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -3932,8 +3932,15 @@ public void truncateTopic(
             @ApiParam(value = "Is authentication required to perform this operation")
             @QueryParam("authoritative") @DefaultValue("false") boolean authoritative){
         validateTopicName(tenant, namespace, encodedTopic);
-        internalTruncateTopic(asyncResponse, authoritative);
-
+        internalTruncateTopicAsync(authoritative)

Review Comment:
   It's better to make this method exclude the authoritative parameter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org