[GitHub] [hive] zabetak commented on a change in pull request #1357: HIVE-23963: UnsupportedOperationException in queries 74 and 84 while applying HiveCardinalityPreservingJoinRule

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #1357:
URL: https://github.com/apache/hive/pull/1357#discussion_r466296959



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelDistribution.java
##########
@@ -81,8 +84,16 @@ public RelDistribution apply(TargetMapping mapping) {
       return this;
     }
     List<Integer> newKeys = new ArrayList<>(keys.size());
+
+    // Instead of using a HashMap for lookup newKeys.add(mapping.getTargetOpt(key)); should be called but not all the
+    // mapping supports that. See HIVE-23963. Replace this when this is fixed in calcite.

Review comment:
       If it is meant to be fixed in Calcite then we should create a JIRA and add an entry in `org.apache.hadoop.hive.ql.optimizer.calcite.Bug`. We could even skip the JIRA creation and move this comment in `Bug` as `CALCITE-X0000_fixed` or something similar.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org