You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/08/17 08:22:20 UTC

[GitHub] [spark] LuciferYang commented on pull request #42523: [SPARK-44806][CONNECT] Move internal client spark-connect-common to be able to test real in-process server with a real RPC client

LuciferYang commented on PR #42523:
URL: https://github.com/apache/spark/pull/42523#issuecomment-1681849488

   > Move the org.apache.spark.sql.connect.client code into new spark-connect-client-jvm-internal module, so that the internal SparkConnectClient code is separated from the client public API, and can be pulled into testing of the server.
   
   Should this part of the PR description be fixed? Move the org.apache.spark.sql.connect.client code into spark-connect-common module?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org