You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/28 08:43:48 UTC

[GitHub] [spark] LantaoJin opened a new pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

LantaoJin opened a new pull request #29890:
URL: https://github.com/apache/spark/pull/29890


   ### What changes were proposed in this pull request?
   In `V2SessionCatalog.convertTransforms()`, partitions only match one bucket column by
   `case BucketTransform(numBuckets, FieldReference(Seq(col))) =>`
   It should be a bug since there is no comment to explain the reason.
   This PR accepts more than one bucket columns for V2 table.
   
   
   ### Why are the changes needed?
   Create a data source V2 table only accept one bucket column, two or more bucket columns in V2 table will show exception `SessionCatalog does not support partition transform ...`.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Add UT.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700521237


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33833/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700500212


   **[Test build #129218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129218/testReport)** for PR 29890 at commit [`eeb19e7`](https://github.com/apache/spark/commit/eeb19e7f188b70864b12f53a2e4943db9a930c60).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #29890:
URL: https://github.com/apache/spark/pull/29890#discussion_r528440617



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/connector/expressions/expressions.scala
##########
@@ -115,11 +115,10 @@ private[sql] final case class BucketTransform(
 }
 
 private[sql] object BucketTransform {

Review comment:
       Looks like you should update DataFrameWriter.scala, functions.scala, functions.py, etc related codes. cc @rdblue, @brkyvz and @zero323 FYI




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700535161






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699881541


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129176/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700500212


   **[Test build #129218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129218/testReport)** for PR 29890 at commit [`eeb19e7`](https://github.com/apache/spark/commit/eeb19e7f188b70864b12f53a2e4943db9a930c60).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699926147






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700535131


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33833/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699877852


   **[Test build #129176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129176/testReport)** for PR 29890 at commit [`b5d4e59`](https://github.com/apache/spark/commit/b5d4e59e1b7c8ca908b36a1bf6bb527437827a40).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700540476


   **[Test build #129226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129226/testReport)** for PR 29890 at commit [`5d85106`](https://github.com/apache/spark/commit/5d85106b520e95e87a25a78eb3e7393cd4590342).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699877189


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700678330


   **[Test build #129218 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129218/testReport)** for PR 29890 at commit [`eeb19e7`](https://github.com/apache/spark/commit/eeb19e7f188b70864b12f53a2e4943db9a930c60).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] rdblue commented on a change in pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #29890:
URL: https://github.com/apache/spark/pull/29890#discussion_r529079681



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/connector/expressions/TransformExtractorSuite.scala
##########
@@ -130,23 +130,32 @@ class TransformExtractorSuite extends SparkFunSuite {
   }
 
   test("Bucket extractor") {
-    val col = ref("a", "b")
-    val bucketTransform = new Transform {
-      override def name: String = "bucket"
-      override def references: Array[NamedReference] = Array(col)
-      override def arguments: Array[Expression] = Array(lit(16), col)
-      override def describe: String = s"bucket(16, ${col.describe})"
+    def checkBucketTransform(cols: Seq[NamedReference], expectedBucketCols: Seq[String]): Unit = {
+      new Transform {
+        override def name: String = "bucket"
+        override def references: Array[NamedReference] = cols.toArray
+        override def arguments: Array[Expression] = Array(lit(16)) ++ cols
+        override def describe: String = s"bucket(${arguments.map(_.describe).mkString(", ")})"
+      } match {
+        case BucketTransform(numBuckets, fieldReferences) =>
+          val bucketColumns = fieldReferences.collect {
+            case FieldReference(parts) => parts.mkString(".")
+          }
+          assert(numBuckets === 16)
+          assert(bucketColumns === expectedBucketCols)
+        case _ =>
+          fail("Did not match BucketTransform extractor")
+      }
     }
 
-    bucketTransform match {
-      case BucketTransform(numBuckets, FieldReference(seq)) =>
-        assert(numBuckets === 16)
-        assert(seq === Seq("a", "b"))
-      case _ =>
-        fail("Did not match BucketTransform extractor")
-    }
+    // CLUSTERED BY (a, b)
+    checkBucketTransform(Seq(ref("a"), ref("b")), Seq("a", "b"))
+    // CLUSTERED BY (a.b)
+    checkBucketTransform(Seq(ref("a", "b")), Seq("a.b"))
+    checkBucketTransform(Seq(ref("a.b")), Seq("a.b"))
+    checkBucketTransform(Seq(ref("`a.b`")), Seq("`a.b`"))
 
-    transform("unknown", ref("a", "b")) match {
+    transform("unknown", ref("c")) match {

Review comment:
       Why did this test case change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700610186


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33842/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699881525


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699881525






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700540476


   **[Test build #129226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129226/testReport)** for PR 29890 at commit [`5d85106`](https://github.com/apache/spark/commit/5d85106b520e95e87a25a78eb3e7393cd4590342).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LantaoJin commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
LantaoJin commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-701096223


   ping @cloud-fan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700019969


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129178/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699877852


   **[Test build #129176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129176/testReport)** for PR 29890 at commit [`b5d4e59`](https://github.com/apache/spark/commit/b5d4e59e1b7c8ca908b36a1bf6bb527437827a40).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700535161


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LantaoJin commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
LantaoJin commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-706906267


   gentle ping @cloud-fan @HyukjinKwon @dongjoon-hyun 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700018637


   **[Test build #129178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129178/testReport)** for PR 29890 at commit [`4cd6f22`](https://github.com/apache/spark/commit/4cd6f220b1027c1e22160d2a3aacf026257572ca).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700680733






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700598729


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33842/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700610203






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699877189






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] github-actions[bot] commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-790195676


   We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699925690


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33793/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699881490


   **[Test build #129176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129176/testReport)** for PR 29890 at commit [`b5d4e59`](https://github.com/apache/spark/commit/b5d4e59e1b7c8ca908b36a1bf6bb527437827a40).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699897315


   **[Test build #129178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129178/testReport)** for PR 29890 at commit [`4cd6f22`](https://github.com/apache/spark/commit/4cd6f220b1027c1e22160d2a3aacf026257572ca).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699877203


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33790/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700019958


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] github-actions[bot] closed pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #29890:
URL: https://github.com/apache/spark/pull/29890


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699918266


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33793/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700746450






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700680733






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699926147






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700744338


   **[Test build #129226 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129226/testReport)** for PR 29890 at commit [`5d85106`](https://github.com/apache/spark/commit/5d85106b520e95e87a25a78eb3e7393cd4590342).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700535168


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33833/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700610203






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700019958






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-699897315


   **[Test build #129178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129178/testReport)** for PR 29890 at commit [`4cd6f22`](https://github.com/apache/spark/commit/4cd6f220b1027c1e22160d2a3aacf026257572ca).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] LantaoJin commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
LantaoJin commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-716925255


   Gentle ping @cloud-fan @HyukjinKwon @dongjoon-hyun again


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #29890: [SPARK-33014][SQL] Support multiple bucket columns in DataSourceV2 table

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29890:
URL: https://github.com/apache/spark/pull/29890#issuecomment-700746450






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org