[GitHub] [hadoop] Hexiaoqiao commented on a change in pull request #2737: HDFS-15869. Network issue while FSEditLogAsync is executing RpcEdit.logSyncNotify can cause the namenode to hang

[GitBox <gi...@apache.org>]

Hexiaoqiao commented on a change in pull request #2737:
URL: https://github.com/apache/hadoop/pull/2737#discussion_r613305815



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java
##########
@@ -117,6 +125,7 @@ void openForWrite(int layoutVersion) throws IOException {
   public void close() {
     super.close();
     stopSyncThread();
+    logSyncNotifyExecutor.shutdown();

Review comment:
       It could meet issue when transition active to standby then transition back here. Because executor has been shutdown and no response will be sent. Moreover I suspect that namenode process could fatal in this case. In my opinion, we do not need to shutdown this executor. FYI. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org