You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Naoki Nose (JIRA)" <ji...@codehaus.org> on 2006/04/29 08:41:19 UTC
[jira] Created: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
the encoding parameter in xml declaration of POM is ignored
------------------------------------------------------------
Key: MNG-2254
URL: http://jira.codehaus.org/browse/MNG-2254
Project: Maven 2
Type: Bug
Reporter: Naoki Nose
Attachments: modello-plugin-xpp3.diff
DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
to fix this problem, We should
- fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
- regenerate maven-model using fixed modello-plugin-xpp3
- fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-2254:
-------------------------------
Fix Version/s: (was: 2.1.x)
2.0.8
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MNG-2254:
-------------------------------
Attachment: MNG-2254.diff
Here is a patch to use XmlReader from plexus-utils 1.4.3-SNAPSHOT from MPLEXUS-11 branch.
Modello change is not absolutely necessary: adding read(InputStream) to read(Reader) is only an enhencement to make people prefer the first one, but using the second one with an XmlReader instance is strictly the same
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=all ]
John Casey updated MNG-2254:
----------------------------
Fix Version: 2.1
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Type: Bug
> Reporter: Naoki Nose
> Fix For: 2.1
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MNG-2254:
-------------------------------
Attachment: MNG-2254_components-new.diff
ok: here is a new patch
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, mng-2254-PomEncoding.tgz, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components-new.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Stefan H?bner (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=comments#action_65078 ]
Stefan Hübner commented on MNG-2254:
------------------------------------
As I just stated in MNG-2255 I think, that ??"...the parser used to read in maven's model isn't the problem really. It's more likely the way the POM is handed to the parser."??
See MNG-2255 for full discussion of the issue.
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Type: Bug
> Reporter: Naoki Nose
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102845 ]
Herve Boutemy commented on MNG-2254:
------------------------------------
see http://docs.codehaus.org/display/MAVENUSER/XML+encoding for the roadmap to XML encoding support in Maven2
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MNG-2254:
-------------------------------
Attachment: MNG-2254_components.diff
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-2254:
------------------------------
Patch Submitted: [Yes]
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MNG-2254:
-------------------------------
Attachment: (was: MNG-2254_components.diff)
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-2254:
-------------------------------
Patch Submitted: (was: [Yes])
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.1.x
>
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Naoki Nose (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=all ]
Naoki Nose updated MNG-2254:
----------------------------
Attachment: modello-plugin-xpp3.diff
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Type: Bug
> Reporter: Naoki Nose
> Attachments: modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MNG-2254:
------------------------------
Component/s: POM
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.1.x
>
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Andrew Williams (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105369 ]
Andrew Williams commented on MNG-2254:
--------------------------------------
Can you please clarify which patches apply and which do not
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_109706 ]
Brian Fox commented on MNG-2254:
--------------------------------
Thanks Herve, the test looks good. I wasn't able to get the patches applied cleanly. Can you update them and then I'll apply and test? (i'm going to add the test to the core suite)
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, mng-2254-PomEncoding.tgz, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=comments#action_64670 ]
Carlos Sanchez commented on MNG-2254:
-------------------------------------
it'd be better to swith to a external xml parser, see MNG-2255
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Type: Bug
> Reporter: Naoki Nose
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105371 ]
Herve Boutemy commented on MNG-2254:
------------------------------------
the 2 latest only are to be applied:
- MNG-2254_artifact.diff for maven/artifact/trunk and maven/components/branches/maven-2.0.x/maven-artifact
- MNG-2254_components.diff for maven/components/trunk and maven/components/branches/maven-2.0.x
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_102856 ]
Jason van Zyl commented on MNG-2254:
------------------------------------
I will take a look, I have walked through everything else this week: plexus and modello, so now I can push in the changes into Maven's core.
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-2254) the encoding parameter in xml declaration
of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy closed MNG-2254.
------------------------------
Assignee: Herve Boutemy (was: Jason van Zyl)
Resolution: Fixed
work done:
- r585265 for trunk
- r585268 for 2.0.x branch
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Herve Boutemy
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, mng-2254-PomEncoding.tgz, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components-new.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_100267 ]
Herve Boutemy commented on MNG-2254:
------------------------------------
for problems about encodings, there are ways to write a Reader that automagically detects the encoding of a XML stream:
see https://rome.dev.java.net/apidocs/0_5/com/sun/syndication/io/XmlReader.html
this permits to use a reader as a source for an XML parser without loosing any information: the magic is done by the reader, not by the parser.
Such a solution would be an easy fix: the actual MavenXpp3Reader signature could be sufficient (even if using an InputStream would be more classical)
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.1.x
>
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Naoki Nose (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=comments#action_64373 ]
Naoki Nose commented on MNG-2254:
---------------------------------
Attached files are the patch to fix this issue.
These files depend on the patch of MXParser which I attached to the following issue.
http://jira.codehaus.org/browse/MNG-2148
using a external standard xml pull parser may be better solution, as discussed in the following issue.
http://jira.codehaus.org/browse/DOXIA-60
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Type: Bug
> Reporter: Naoki Nose
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MNG-2254:
-------------------------------
Attachment: MNG-2254-2.diff
Here is a new patch fixing encoding detection for pom.xml, settings.xml and profiles.xml
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MNG-2254:
-------------------------------
Attachment: mng-2254-PomEncoding.tgz
Hi Brian,
Here is an IT to check that pom.xml encoding is properly detected: the sample pom.xml is in utf-16, then if encoding is not detected, the build simply fails (no complicated test to check that an accentuated character would have been correctly read)
I checked that it fails without the patch, not that it works with the patch applied...
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, mng-2254-PomEncoding.tgz, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MNG-2254:
-------------------------------
Attachment: MNG-2254.diff
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MNG-2254:
-------------------------------
Attachment: MNG-2254_components.diff
MNG-2254_artifact.diff
splitted the patch into 2 pieces since maven-artifact has been moved to artifact
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MNG-2254:
-------------------------------
Attachment: (was: MNG-2254.diff)
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MNG-2254) the encoding parameter in
xml declaration of POM is ignored
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105371 ]
Herve Boutemy edited comment on MNG-2254 at 8/21/07 5:02 PM:
-------------------------------------------------------------
the 2 latest only are to be applied:
- {{MNG-2254_artifact.diff}} for maven/artifact/trunk and maven/components/branches/maven-2.0.x/maven-artifact
- {{MNG-2254_components.diff}} for maven/components/trunk and maven/components/branches/maven-2.0.x
was:
the 2 latest only are to be applied:
- MNG-2254_artifact.diff for maven/artifact/trunk and maven/components/branches/maven-2.0.x/maven-artifact
- MNG-2254_components.diff for maven/components/trunk and maven/components/branches/maven-2.0.x
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_100268 ]
Jason van Zyl commented on MNG-2254:
------------------------------------
Herve, if you want take a crack at this I would certainly incorporate this into Modello.
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.1.x
>
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_109597 ]
Brian Fox commented on MNG-2254:
--------------------------------
Can someone make an IT for this? See the instructions here: http://docs.codehaus.org/display/MAVEN/Creating+a+Maven+Integration+Test
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Issue Type: Bug
> Components: POM::Encoding
> Reporter: Naoki Nose
> Assignee: Jason van Zyl
> Fix For: 2.0.8
>
> Attachments: DefaultMavenProjectBuilder.diff, MNG-2254-2.diff, MNG-2254.diff, MNG-2254_artifact.diff, MNG-2254_components.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2254) the encoding parameter in xml
declaration of POM is ignored
Posted by "Naoki Nose (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2254?page=all ]
Naoki Nose updated MNG-2254:
----------------------------
Attachment: DefaultMavenProjectBuilder.diff
> the encoding parameter in xml declaration of POM is ignored
> ------------------------------------------------------------
>
> Key: MNG-2254
> URL: http://jira.codehaus.org/browse/MNG-2254
> Project: Maven 2
> Type: Bug
> Reporter: Naoki Nose
> Attachments: DefaultMavenProjectBuilder.diff, modello-plugin-xpp3.diff
>
>
> DefaultMavenProjectBuilder reads POM in system default character encoding, and the encoding parameter in xml declartion is ignored.
> to fix this problem, We should
> - fix modello-plugin-xpp3 to use the xml parser which is able to handle the encoding parameter properly
> - regenerate maven-model using fixed modello-plugin-xpp3
> - fix DefaultMavenProjectBuilder to use regenerated maven-model properly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira