You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/10 15:23:19 UTC

[GitHub] [pulsar] hangc0276 commented on a change in pull request #10529: Fix partitioned system topic check bug

hangc0276 commented on a change in pull request #10529:
URL: https://github.com/apache/pulsar/pull/10529#discussion_r629454124



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/systopic/SystemTopicClient.java
##########
@@ -168,7 +168,10 @@
     }
 
     static boolean isSystemTopic(TopicName topicName) {
-        return EventsTopicNames.NAMESPACE_EVENTS_LOCAL_NAME.equals(topicName.getLocalName());
+        String localName = topicName.getLocalName();

Review comment:
       > what about
   > `topicName.getLocalName().startsWith(EventsTopicNames.NAMESPACE_EVENTS_LOCAL_NAME);`
   
   @linlinnn if the topic name is __change_events_v1, using startsWith, it will return `true`. However it isn't system topic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org