You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2016/09/20 17:45:47 UTC
[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4479
Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
......................................................................
IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
The SQL statements generated from COMPUTE INCREMENTAL STATS
did not properly quote identifiers when incrementally updating
the stats for newly added partitions.
Our existing tests did not catch this case because the code paths
for doing the initial stats computation and the incremental stats
computation are different, in particular, the code for generating
the SQL statements.
Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
---
M fe/src/main/java/com/cloudera/impala/catalog/HdfsPartition.java
M testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
2 files changed, 42 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/4479/1
--
To view, visit http://gerrit.cloudera.org:8080/4479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4479/1//COMMIT_MSG
Commit Message:
PS1, Line 13: Our existing tests did not catch this case because the code paths
: for doing the initial stats computation and the incremental stats
: computation are different
Do you mean the test actually ran COMPUTE STATS (not incremental) for the initial stats computation?
--
To view, visit http://gerrit.cloudera.org:8080/4479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
......................................................................
IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
The SQL statements generated from COMPUTE INCREMENTAL STATS
did not properly quote identifiers when incrementally updating
the stats for newly added partitions.
Our existing tests did not catch this case because the code paths
for doing the initial stats computation and the incremental stats
computation are different, in particular, the code for generating
the SQL statements.
Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
Reviewed-on: http://gerrit.cloudera.org:8080/4479
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Internal Jenkins
---
M fe/src/main/java/com/cloudera/impala/catalog/HdfsPartition.java
M testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test
2 files changed, 42 insertions(+), 25 deletions(-)
Approvals:
Henry Robinson: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4479/1//COMMIT_MSG
Commit Message:
PS1, Line 13: Our existing tests did not catch this case because the code paths
: for doing the initial stats computation and the incremental stats
: computation are different
> Do you mean the test actually ran COMPUTE STATS (not incremental) for the i
No, I mean we tested compute incremental stats on a table for which we never computed incremental stats in the past. We go down a different code path if we have a table with partial incremental stats.
--
To view, visit http://gerrit.cloudera.org:8080/4479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63adcc45dc964ce769107bf4139fc4566937bb96
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes