You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/26 17:16:31 UTC
[GitHub] [airflow] josh-fell opened a new issue #17235: Connection inputs in Extra field are overwritten by custom form widget fields
josh-fell opened a new issue #17235:
URL: https://github.com/apache/airflow/issues/17235
**Apache Airflow version**:
2.1.0
**What happened**:
There are several hooks that still use optional parameters from the classic `Extra` field. However, when creating the connection the `Extra` field is overwritten with values from the custom fields that are included in the form. Because the `Extra` field is overwritten, these optional parameters cannot be used by the hook.
For example, in the `AzureDataFactoryHook`, If `resource_group_name` or `factory_name` are not provided when initializing the hook, it defaults to the value specified in the connection extras. Using the Azure Data Factory connection form, here is the initial connection submission:
After saving the connection, the `Extra` field is overwritten with the custom fields that use "extras" under the hood:
**What you expected to happen**:
Wavering slightly but I would have initially expected that the `Extra` field wasn't overwritten but updated with both the custom field "extras" plus the originally configured values in the `Extra` field. However, a better UX would be that the values used in the `Extra` field should be separate custom fields for these hooks and the `Extra` field is hidden. Perhaps it's even both?
**How to reproduce it**:
install either the Microsoft Azure or Snowflake providers, attempt to create a connection for either the Snowflake, Azure Data Factory, Azure Container Volume, or Azure types with the `Extra` field populated prior to saving the form.
**Anything else we need to know**:
Happy to submit PRs to fix this issue. 🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed issue #17235: Connection inputs in Extra field are overwritten by custom form widget fields
Posted by GitBox <gi...@apache.org>.
uranusjr closed issue #17235:
URL: https://github.com/apache/airflow/issues/17235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #17235: Connection inputs in Extra field are overwritten by custom form widget fields
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17235:
URL: https://github.com/apache/airflow/issues/17235#issuecomment-886893971
Yeah. Smart merging of the fields is best approach. There are already quite a few connections where the "extra" field is hidden (when available extra are exhaustive) but I think it would not be too difficult to make it works smart and automatically split/merge both approaches. Feel free to provide PR for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org