You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by fabriziocucci <gi...@git.apache.org> on 2017/08/03 09:09:39 UTC
[GitHub] logging-log4j2 pull request #105: Modernized (Java 8 style) markers examples
GitHub user fabriziocucci opened a pull request:
https://github.com/apache/logging-log4j2/pull/105
Modernized (Java 8 style) markers examples
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fabriziocucci/logging-log4j2 patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/logging-log4j2/pull/105.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #105
----
commit 5ab3899fdbd426fa4419e8d0f093d2e19b26bfc8
Author: Fabrizio Cucci <fa...@gmail.com>
Date: 2017-08-03T09:09:30Z
Modernized (Java 8 style) markers examples
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #105: Modernized (Java 8 style) markers examples
Posted by fabriziocucci <gi...@git.apache.org>.
Github user fabriziocucci commented on the issue:
https://github.com/apache/logging-log4j2/pull/105
@garydgregory sorry, I completely missed the requirements section:
> Log4j 2.4 and greater requires Java 7, versions 2.0-alpha1 to 2.3 required Java 6.
I will revert all Java 8 stuff and keep the entry API changes as you suggested.
Out of curiosity, is there any plan to ditch Java 7 support?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #105: Modernized (Java 8 style) markers examples
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/105
Fixed in Git master and tracked with https://issues.apache.org/jira/browse/LOG4J2-2029
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 pull request #105: Marker examples should not use deprecate f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/logging-log4j2/pull/105
---
[GitHub] logging-log4j2 issue #105: Modernized (Java 8 style) markers examples
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/logging-log4j2/pull/105
Our base requirement is still Java 7. So we cannot just yet take this whole patch unless we split the examples into Java 7 and Java 8. I would like to take the changes for the entry APIs though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #105: Modernized (Java 8 style) markers examples
Posted by jvz <gi...@git.apache.org>.
Github user jvz commented on the issue:
https://github.com/apache/logging-log4j2/pull/105
No real plan to upgrade to Java 8 for at least another year or so I believe. Too many people still depending on 7 as a baseline. It would be neat if there were some creative way to support multiple versions of Java similar to how Babel works for JS, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #105: Marker examples should not use deprecate flow API...
Posted by fabriziocucci <gi...@git.apache.org>.
Github user fabriziocucci commented on the issue:
https://github.com/apache/logging-log4j2/pull/105
I guess this one can be closed now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] logging-log4j2 issue #105: Modernized (Java 8 style) markers examples
Posted by fabriziocucci <gi...@git.apache.org>.
Github user fabriziocucci commented on the issue:
https://github.com/apache/logging-log4j2/pull/105
Done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---