You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/03 18:38:00 UTC
[jira] [Work logged] (GOBBLIN-939) Integrate usage of env variables
in gobblin scripts and configs
[ https://issues.apache.org/jira/browse/GOBBLIN-939?focusedWorklogId=352870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352870 ]
ASF GitHub Bot logged work on GOBBLIN-939:
------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Dec/19 18:37
Start Date: 03/Dec/19 18:37
Worklog Time Spent: 10m
Work Description: Will-Lo commented on pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and standardize configs
URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r353352604
##########
File path: conf/gobblin-as-service/application.conf
##########
@@ -16,11 +16,12 @@
#
# Gobblin-As-Service configuration properties
-gobblin.service.work.dir=/tmp/gobblin-as-service
+gobblin.work.dir=${GOBBLIN_WORK_DIR}
Review comment:
So I tested the scripts and some execution modes still seem to have references to the old variable of the old directory e.g.`gobblin.service.work.dir`. Could we fix these to ensure the scripts are all working?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 352870)
Time Spent: 3h 20m (was: 3h 10m)
> Integrate usage of env variables in gobblin scripts and configs
> ---------------------------------------------------------------
>
> Key: GOBBLIN-939
> URL: https://issues.apache.org/jira/browse/GOBBLIN-939
> Project: Apache Gobblin
> Issue Type: Improvement
> Affects Versions: 0.14.0
> Reporter: Jay Sen
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> 1. standardize config with ENV variables
> 2. define default env variables in gobblin-env.sh
--
This message was sent by Atlassian Jira
(v8.3.4#803005)