You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/18 05:12:59 UTC
[GitHub] [shardingsphere] lanchengx opened a new pull request #11874: Remove SCTL
lanchengx opened a new pull request #11874:
URL: https://github.com/apache/shardingsphere/pull/11874
For #11677.
Changes proposed in this pull request:
- Delete SCTL related classes;
- Modify the import of the class and the corresponding test class;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #11874: Remove SCTL
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11874:
URL: https://github.com/apache/shardingsphere/pull/11874#issuecomment-900986929
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11874](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2be6f5a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/147d8a12fc82e9d4667861583d6bd116a13f4e62?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (147d8a1) will **decrease** coverage by `0.25%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11874 +/- ##
============================================
- Coverage 63.23% 62.97% -0.26%
+ Complexity 1230 1216 -14
============================================
Files 2327 2300 -27
Lines 35176 34909 -267
Branches 6129 6075 -54
============================================
- Hits 22242 21985 -257
- Misses 11136 11140 +4
+ Partials 1798 1784 -14
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/shardingsphere/infra/hint/HintManager.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L0hpbnRNYW5hZ2VyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ardingsphere/infra/route/context/RouteContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL2NvbnRleHQvUm91dGVDb250ZXh0LmphdmE=) | `94.11% <ø> (ø)` | |
| [.../shardingsphere/infra/route/context/RouteUnit.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL2NvbnRleHQvUm91dGVVbml0LmphdmE=) | `85.71% <ø> (ø)` | |
| [...ext/distsql/ral/common/hint/HintManagerHolder.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRNYW5hZ2VySG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...text/distsql/ral/common/hint/HintShardingType.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTaGFyZGluZ1R5cGUuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...executor/AddShardingHintDatabaseValueExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0FkZFNoYXJkaW5nSGludERhdGFiYXNlVmFsdWVFeGVjdXRvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...nt/executor/AddShardingHintTableValueExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0FkZFNoYXJkaW5nSGludFRhYmxlVmFsdWVFeGVjdXRvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...ql/ral/common/hint/executor/ClearHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0NsZWFySGludEV4ZWN1dG9yLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../executor/ClearReadwriteSplittingHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0NsZWFyUmVhZHdyaXRlU3BsaXR0aW5nSGludEV4ZWN1dG9yLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ommon/hint/executor/ClearShardingHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0NsZWFyU2hhcmRpbmdIaW50RXhlY3V0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [39 more](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [367761f...2be6f5a](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #11874: Remove SCTL
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11874:
URL: https://github.com/apache/shardingsphere/pull/11874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #11874: Remove SCTL
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #11874:
URL: https://github.com/apache/shardingsphere/pull/11874#discussion_r690964181
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/SQLUtil.java
##########
@@ -256,4 +260,21 @@ public static ExpressionSegment createLiteralExpression(final ASTNode astNode, f
public static String trimSemicolon(final String sql) {
return sql.endsWith(SQL_END) ? sql.substring(0, sql.length() - 1) : sql;
}
+
+ /**
+ * Trim the comment of sql.
+ *
+ * @param sql SQL to be trim
+ * @return remove comment from SQL
+ */
+ public static String trimComment(final String sql) {
+ String result = sql;
+ if (sql.startsWith(COMMENT_PREFIX)) {
+ result = result.substring(sql.indexOf(COMMENT_SUFFIX) + 2);
+ }
+ if (sql.endsWith(SQL_END)) {
+ result = result.substring(0, result.length() - 1);
+ }
+ return result.trim();
Review comment:
Why do we need to remove the comment from the SQL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #11874: Remove SCTL
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #11874:
URL: https://github.com/apache/shardingsphere/pull/11874#discussion_r690964181
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/SQLUtil.java
##########
@@ -256,4 +260,21 @@ public static ExpressionSegment createLiteralExpression(final ASTNode astNode, f
public static String trimSemicolon(final String sql) {
return sql.endsWith(SQL_END) ? sql.substring(0, sql.length() - 1) : sql;
}
+
+ /**
+ * Trim the comment of sql.
+ *
+ * @param sql SQL to be trim
+ * @return remove comment from SQL
+ */
+ public static String trimComment(final String sql) {
+ String result = sql;
+ if (sql.startsWith(COMMENT_PREFIX)) {
+ result = result.substring(sql.indexOf(COMMENT_SUFFIX) + 2);
+ }
+ if (sql.endsWith(SQL_END)) {
+ result = result.substring(0, result.length() - 1);
+ }
+ return result.trim();
Review comment:
Why do we need to remove the comment from the SQL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #11874: Remove SCTL
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11874:
URL: https://github.com/apache/shardingsphere/pull/11874#issuecomment-900986929
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11874](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2be6f5a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/147d8a12fc82e9d4667861583d6bd116a13f4e62?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (147d8a1) will **decrease** coverage by `0.25%`.
> The diff coverage is `12.50%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11874 +/- ##
============================================
- Coverage 63.23% 62.97% -0.26%
+ Complexity 1230 1216 -14
============================================
Files 2327 2300 -27
Lines 35176 34909 -267
Branches 6129 6075 -54
============================================
- Hits 22242 21985 -257
- Misses 11136 11140 +4
+ Partials 1798 1784 -14
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/shardingsphere/infra/hint/HintManager.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9oaW50L0hpbnRNYW5hZ2VyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ardingsphere/infra/route/context/RouteContext.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL2NvbnRleHQvUm91dGVDb250ZXh0LmphdmE=) | `94.11% <ø> (ø)` | |
| [.../shardingsphere/infra/route/context/RouteUnit.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL2NvbnRleHQvUm91dGVVbml0LmphdmE=) | `85.71% <ø> (ø)` | |
| [...ext/distsql/ral/common/hint/HintManagerHolder.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRNYW5hZ2VySG9sZGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...text/distsql/ral/common/hint/HintShardingType.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTaGFyZGluZ1R5cGUuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...executor/AddShardingHintDatabaseValueExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0FkZFNoYXJkaW5nSGludERhdGFiYXNlVmFsdWVFeGVjdXRvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...nt/executor/AddShardingHintTableValueExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0FkZFNoYXJkaW5nSGludFRhYmxlVmFsdWVFeGVjdXRvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...ql/ral/common/hint/executor/ClearHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0NsZWFySGludEV4ZWN1dG9yLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../executor/ClearReadwriteSplittingHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0NsZWFyUmVhZHdyaXRlU3BsaXR0aW5nSGludEV4ZWN1dG9yLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ommon/hint/executor/ClearShardingHintExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L2V4ZWN1dG9yL0NsZWFyU2hhcmRpbmdIaW50RXhlY3V0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [39 more](https://codecov.io/gh/apache/shardingsphere/pull/11874/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [367761f...2be6f5a](https://codecov.io/gh/apache/shardingsphere/pull/11874?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx commented on a change in pull request #11874: Remove SCTL
Posted by GitBox <gi...@apache.org>.
lanchengx commented on a change in pull request #11874:
URL: https://github.com/apache/shardingsphere/pull/11874#discussion_r690986744
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/SQLUtil.java
##########
@@ -256,4 +260,21 @@ public static ExpressionSegment createLiteralExpression(final ASTNode astNode, f
public static String trimSemicolon(final String sql) {
return sql.endsWith(SQL_END) ? sql.substring(0, sql.length() - 1) : sql;
}
+
+ /**
+ * Trim the comment of sql.
+ *
+ * @param sql SQL to be trim
+ * @return remove comment from SQL
+ */
+ public static String trimComment(final String sql) {
+ String result = sql;
+ if (sql.startsWith(COMMENT_PREFIX)) {
+ result = result.substring(sql.indexOf(COMMENT_SUFFIX) + 2);
+ }
+ if (sql.endsWith(SQL_END)) {
+ result = result.substring(0, result.length() - 1);
+ }
+ return result.trim();
Review comment:
In order to verify whether there are only comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #11874: Remove SCTL
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11874:
URL: https://github.com/apache/shardingsphere/pull/11874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] lanchengx commented on a change in pull request #11874: Remove SCTL
Posted by GitBox <gi...@apache.org>.
lanchengx commented on a change in pull request #11874:
URL: https://github.com/apache/shardingsphere/pull/11874#discussion_r690986744
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/SQLUtil.java
##########
@@ -256,4 +260,21 @@ public static ExpressionSegment createLiteralExpression(final ASTNode astNode, f
public static String trimSemicolon(final String sql) {
return sql.endsWith(SQL_END) ? sql.substring(0, sql.length() - 1) : sql;
}
+
+ /**
+ * Trim the comment of sql.
+ *
+ * @param sql SQL to be trim
+ * @return remove comment from SQL
+ */
+ public static String trimComment(final String sql) {
+ String result = sql;
+ if (sql.startsWith(COMMENT_PREFIX)) {
+ result = result.substring(sql.indexOf(COMMENT_SUFFIX) + 2);
+ }
+ if (sql.endsWith(SQL_END)) {
+ result = result.substring(0, result.length() - 1);
+ }
+ return result.trim();
Review comment:
In order to verify whether there are only comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org