[GitHub] [airflow] ashb commented on a change in pull request #16954: PythonVritualenvOperator - Feature: Add support for private pypi repo packages in requirements

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #16954:
URL: https://github.com/apache/airflow/pull/16954#discussion_r669505693



##########
File path: airflow/utils/python_virtualenv.py
##########
@@ -88,12 +124,15 @@ def prepare_virtualenv(
     :type system_site_packages: bool
     :param requirements: List of additional python packages
     :type requirements: List[str]
-    :return: Path to a binary file with Python in a virtual environment.
+    :param connection_id: The private repository connection_id
+     case there are private packages to install.

Review comment:
       ```suggestion
       :param connection_id: The connection ID of an http/https connection to use as the index url for installing
           pacakges from a private PyPi repository
   ```

##########
File path: airflow/utils/python_virtualenv.py
##########
@@ -88,12 +124,15 @@ def prepare_virtualenv(
     :type system_site_packages: bool
     :param requirements: List of additional python packages
     :type requirements: List[str]
-    :return: Path to a binary file with Python in a virtual environment.
+    :param connection_id: The private repository connection_id
+     case there are private packages to install.
+    :type connection_id: str
     :rtype: str
     """
     virtualenv_cmd = _generate_virtualenv_cmd(venv_directory, python_bin, system_site_packages)
     execute_in_subprocess(virtualenv_cmd)
-    pip_cmd = _generate_pip_install_cmd(venv_directory, requirements)
+    pip_cmd = _generate_pip_install_cmd(
+        venv_directory, requirements, connection_id)

Review comment:
       ```suggestion
       pip_cmd = _generate_pip_install_cmd(venv_directory, requirements, connection_id)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org