You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/12 13:40:57 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #13435: ARROW-16753: [C++] Add a FileSelector flag that enables traversal of a dir with some restricted content

pitrou commented on code in PR #13435:
URL: https://github.com/apache/arrow/pull/13435#discussion_r918985843


##########
cpp/src/arrow/filesystem/filesystem.h:
##########
@@ -128,12 +128,14 @@ struct ARROW_EXPORT FileSelector {
   /// The behavior if `base_dir` isn't found in the filesystem.  If false,
   /// an error is returned.  If true, an empty selection is returned.
   bool allow_not_found;
+  /// The behavior if errors occur such as access denied during directory traversal.
+  bool allow_errors;

Review Comment:
   Perhaps this should be more explicitly called `bool ignore_permission_errors` or something similar?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org