You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "craig-rueda (via GitHub)" <gi...@apache.org> on 2023/03/02 03:02:01 UTC
[GitHub] [superset] craig-rueda commented on a diff in pull request #23114: chore: add execution_id to any available report logs
craig-rueda commented on code in PR #23114:
URL: https://github.com/apache/superset/pull/23114#discussion_r1122551088
##########
superset/utils/webdriver.py:
##########
@@ -198,10 +202,11 @@ def get_screenshot(
]
logger.debug("Wait %i seconds for chart animation", selenium_animation_wait)
sleep(selenium_animation_wait)
- logger.debug(
- "Taking a PNG screenshot of url %s as user %s",
+ logger.info(
+ "Taking a PNG screenshot of url %s as user %s with execution_id: %s",
Review Comment:
I think this should be `debug`, as it's cluttering things unnecessarily. We can leverage the logging context if you wanted to add `execution_id` to the rendered log's JSON, which will land in the logging aggregator as a field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org