[GitHub] [spark] xuanyuanking commented on a change in pull request #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint

[GitBox <gi...@apache.org>]

xuanyuanking commented on a change in pull request #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint
URL: https://github.com/apache/spark/pull/25971#discussion_r335921865
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala
 ##########
 @@ -30,22 +30,27 @@ import org.apache.spark.util.{RpcUtils, ThreadUtils}
 private[spark]
 class BlockManagerMaster(
     var driverEndpoint: RpcEndpointRef,
+    var driverHeartbeatEndPoint: RpcEndpointRef,
     conf: SparkConf,
     isDriver: Boolean)
   extends Logging {
 
   val timeout = RpcUtils.askRpcTimeout(conf)
 
   /** Remove a dead executor from the driver endpoint. This is only called on the driver side. */
+
   def removeExecutor(execId: String): Unit = {
+    driverHeartbeatEndPoint.askSync[Boolean](RemoveExecutor(execId))
     tell(RemoveExecutor(execId))
     logInfo("Removed " + execId + " successfully in removeExecutor")
   }
 
   /** Request removal of a dead executor from the driver endpoint.
    *  This is only called on the driver side. Non-blocking
    */
+
 
 Review comment:
   ditto

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org