You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "hqhq1025 (via GitHub)" <gi...@apache.org> on 2026/09/05 10:16:07 UTC
Re: [PR] docs(architecture): audit Model access group against implementation [maka]
hqhq1025 commented on code in PR #4794:
URL: https://github.com/apache/maka/pull/4794#discussion_r3940257159
##########
docs/architecture/openai-responses-incremental-transport.md:
##########
@@ -1,3 +1,15 @@
+---
+doc_id: architecture.openai-responses-incremental-transport
+title: "OpenAI Responses incremental transport"
+language: en
+source_language: en
+implementation_status: current
Review Comment:
**[P2] Reconcile `current` status with the implemented transport**
The new `implementation_status: current` and `last_verified` metadata make the unchanged present-tense statement at line 36 inaccurate: the exact-head implementation already plans a turn continuation in `packages/runtime/src/model-adapter.ts:281-301`, slices to the suffix in `openai-responses-continuation.ts:67-82`, and sends that delta when the WebSocket request properties match in `openai-responses-websocket.ts:280-313`. Please mark the problem statement as the pre-optimization state (as the other audited document does) or rewrite it in historical tense before declaring the document current.
##########
docs/model-metadata-firstscreen-optimization.md:
##########
@@ -75,7 +91,7 @@ Full metadata remains available to the main process and lazy-loaded SettingsModa
Acceptance criteria:
- The startup entry and all of its static transitive dependencies exclude `model-metadata.generated.ts`, `model-metadata.ts`, `provider-registry.ts`, `model-catalog.ts`, and `model-thinking.ts`.
-- The startup path no longer statically depends on the renderer's `model-catalog-choices.ts` or `chat-model-selection.ts`.
+- The startup path no longer statically depends on the renderer's `model-catalog-choices.ts` or `shell-chat-model-selection.ts`.
Review Comment:
**[P2] Keep the lightweight selector out of this exclusion**
This renamed acceptance criterion is false on the exact head. `apps/desktop/src/renderer/app-shell.tsx:213` statically imports `useShellChatModel`; `apps/desktop/src/renderer/use-shell-chat-model.ts:31-37` then statically imports `./shell-chat-model-selection.js`, and `apps/desktop/renderer-architecture.json:4306-4310` records that dependency. The same chain remains on current `main`. The implemented optimization keeps this lightweight selector on the startup path while removing the heavy metadata dependencies. Please describe that actual boundary or remove `shell-chat-model-selection.ts` from this exclusion, and make the corresponding correction in the Chinese criterion at line 169.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org