You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/12/02 16:13:16 UTC
[GitHub] [avro] jjaakola-aiven opened a new pull request, #1995: AVRO-3680: [Python] allow to disable name validation
jjaakola-aiven opened a new pull request, #1995:
URL: https://github.com/apache/avro/pull/1995
## Contribution Checklist
## What is the purpose of the change
https://issues.apache.org/jira/browse/AVRO-3680
For interoperability the Python parsing API allows disabling the name validation. It is possible to create schema with names having e.g. dashes from Java SDK. The Python name validation is stricter and follows the Avro specification.
## Verifying this change
This change added tests and can be verified as follows:
* Moved existing tests for `Name` and `Names` to `/lang/py/avro/test/test_name.py`.
* Added tests for invalid names when parsing with new `validate_names` flag set to false.
## Documentation
- Does this pull request introduce a new feature? **yes**
- If yes, how is the feature documented? **not documented**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] NotoriousPyro commented on pull request #1995: AVRO-3680: [Python] allow to disable name validation
Posted by GitBox <gi...@apache.org>.
NotoriousPyro commented on PR #1995:
URL: https://github.com/apache/avro/pull/1995#issuecomment-1339584755
If the python validation is stricter, is the bug not with Java SDK? (which should be more strict to prevent creating such names)
It seems the `lang/js` and a few others also restrict from using hyphens and the like. They too would need updating to allow hyphens, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1995: AVRO-3680: [Python] allow to disable name validation
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged PR #1995:
URL: https://github.com/apache/avro/pull/1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] jjaakola-aiven commented on pull request #1995: AVRO-3680: [Python] allow to disable name validation
Posted by GitBox <gi...@apache.org>.
jjaakola-aiven commented on PR #1995:
URL: https://github.com/apache/avro/pull/1995#issuecomment-1340557567
@NotoriousPyro I do also feel that Java is too lenient and should follow the spec. The actual issue is that there are existing schemas in the wild with names that are not compliant. So the workaround to disable name validation is needed. For new data I think the validation should be enabled, also on Java SDK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1995: AVRO-3680: [Python] allow to disable name validation
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #1995:
URL: https://github.com/apache/avro/pull/1995#issuecomment-1342887812
@NotoriousPyro There is a current discussion on the mailing list noted in the JIRA -- the issue is that some systems rely on the "tolerance" that has existed for non-compliant names in the Java SDK.
To guarantee interoperability today, the validate_names option should definitely be set to `True` (at time of writing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1995: AVRO-3680: [Python] allow to disable name validation
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #1995:
URL: https://github.com/apache/avro/pull/1995#issuecomment-1335563883
N.B. One of the build failures is due to https://issues.apache.org/jira/browse/AVRO-3681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org