You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/15 20:58:46 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
MaxGekk opened a new pull request #28549:
URL: https://github.com/apache/spark/pull/28549
### What changes were proposed in this pull request?
Change timestamp casting to int in ANSI and non-codegen mode, and make the error message consistent to the error messages in the codegen mode. In particular, casting to int is implemented in the same way as casting to short and byte.
### Why are the changes needed?
1. The error message in the non-codegen mode is diversed from the error message in the codegen mode.
2. The error message contains intermediate results that could confuse.
### Does this PR introduce _any_ user-facing change?
Yes. Before the changes, the error message of casting timestamp to int contains intermediate result but after the changes it contains the input values which causes arithmetic overflow.
### How was this patch tested?
By running the modified test suite `AnsiCastSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28549:
URL: https://github.com/apache/spark/pull/28549#issuecomment-629481016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28549:
URL: https://github.com/apache/spark/pull/28549#issuecomment-629582850
**[Test build #122694 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122694/testReport)** for PR 28549 at commit [`f561971`](https://github.com/apache/spark/commit/f561971cb624ffffb721a73429ab37b32580eda7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28549:
URL: https://github.com/apache/spark/pull/28549#issuecomment-629946729
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28549:
URL: https://github.com/apache/spark/pull/28549
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28549:
URL: https://github.com/apache/spark/pull/28549#issuecomment-629484466
**[Test build #122694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122694/testReport)** for PR 28549 at commit [`f561971`](https://github.com/apache/spark/commit/f561971cb624ffffb721a73429ab37b32580eda7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28549:
URL: https://github.com/apache/spark/pull/28549#issuecomment-629583001
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28549:
URL: https://github.com/apache/spark/pull/28549#issuecomment-629583001
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28549:
URL: https://github.com/apache/spark/pull/28549#issuecomment-629481016
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28549:
URL: https://github.com/apache/spark/pull/28549#issuecomment-629484466
**[Test build #122694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122694/testReport)** for PR 28549 at commit [`f561971`](https://github.com/apache/spark/commit/f561971cb624ffffb721a73429ab37b32580eda7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28549: [SPARK-31727][SQL] Fix error message of casting timestamp to int in ANSI non-codegen mode
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28549:
URL: https://github.com/apache/spark/pull/28549#issuecomment-629587533
@cloud-fan @HyukjinKwon Could you review the PR, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org