You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Gregory Chanan <gc...@cloudera.com> on 2014/12/08 23:25:22 UTC

Review Request 28826: SOLR-6625: HttpClient callback in HttpSolrServer

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28826/
-----------------------------------------------------------

Review request for lucene and Mark Miller.


Repository: lucene


Description
-------

See: https://issues.apache.org/jira/browse/SOLR-6625


Diffs
-----

  trunk/solr/core/src/java/org/apache/solr/core/ConfigSolr.java 1643097 
  trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java 1643097 
  trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java 1643097 
  trunk/solr/core/src/java/org/apache/solr/core/CoreContainer.java 1643097 
  trunk/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java 1643097 
  trunk/solr/core/src/java/org/apache/solr/update/StreamingSolrServers.java 1643097 
  trunk/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java 1643097 
  trunk/solr/core/src/java/org/apache/solr/util/SolrCLI.java 1643097 
  trunk/solr/core/src/test-files/solr/solr-httpcallback.xml PRE-CREATION 
  trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java 1643097 
  trunk/solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java 1643097 
  trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServer.java 1643097 
  trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientRequestCallback.java PRE-CREATION 
  trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientRequestCallbackUtil.java PRE-CREATION 
  trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrServer.java 1643097 
  trunk/solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrServerTest.java 1643097 
  trunk/solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServerTest.java 1643097 

Diff: https://reviews.apache.org/r/28826/diff/


Testing
-------


Thanks,

Gregory Chanan

Re: Review Request 28826: SOLR-6625: HttpClient callback in HttpSolrServer

Posted by Mark Miller <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28826/#review64300
-----------------------------------------------------------



trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrServer.java
<https://reviews.apache.org/r/28826/#comment106934>

    mabye fix the space before processor too


- Mark Miller


On Dec. 8, 2014, 10:25 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28826/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 10:25 p.m.)
> 
> 
> Review request for lucene and Mark Miller.
> 
> 
> Repository: lucene
> 
> 
> Description
> -------
> 
> See: https://issues.apache.org/jira/browse/SOLR-6625
> 
> 
> Diffs
> -----
> 
>   trunk/solr/core/src/java/org/apache/solr/core/ConfigSolr.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/core/CoreContainer.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/update/StreamingSolrServers.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/util/SolrCLI.java 1643097 
>   trunk/solr/core/src/test-files/solr/solr-httpcallback.xml PRE-CREATION 
>   trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java 1643097 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java 1643097 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServer.java 1643097 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientRequestCallback.java PRE-CREATION 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientRequestCallbackUtil.java PRE-CREATION 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrServer.java 1643097 
>   trunk/solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrServerTest.java 1643097 
>   trunk/solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServerTest.java 1643097 
> 
> Diff: https://reviews.apache.org/r/28826/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>

Re: Review Request 28826: SOLR-6625: HttpClient callback in HttpSolrServer

Posted by Mike Drob <md...@mdrob.com>.

> On Dec. 8, 2014, 11:04 p.m., Mike Drob wrote:
> > Which branch is this against? It doesn't apply to

Ignore the branch question - I had a dirty workspace and didn't realize it.


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28826/#review64298
-----------------------------------------------------------


On Dec. 8, 2014, 10:25 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28826/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 10:25 p.m.)
> 
> 
> Review request for lucene and Mark Miller.
> 
> 
> Repository: lucene
> 
> 
> Description
> -------
> 
> See: https://issues.apache.org/jira/browse/SOLR-6625
> 
> 
> Diffs
> -----
> 
>   trunk/solr/core/src/java/org/apache/solr/core/ConfigSolr.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/core/CoreContainer.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/update/StreamingSolrServers.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/util/SolrCLI.java 1643097 
>   trunk/solr/core/src/test-files/solr/solr-httpcallback.xml PRE-CREATION 
>   trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java 1643097 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java 1643097 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServer.java 1643097 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientRequestCallback.java PRE-CREATION 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientRequestCallbackUtil.java PRE-CREATION 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrServer.java 1643097 
>   trunk/solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrServerTest.java 1643097 
>   trunk/solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServerTest.java 1643097 
> 
> Diff: https://reviews.apache.org/r/28826/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>

Re: Review Request 28826: SOLR-6625: HttpClient callback in HttpSolrServer

Posted by Mike Drob <md...@mdrob.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28826/#review64298
-----------------------------------------------------------


Which branch is this against? It doesn't apply to


trunk/solr/core/src/java/org/apache/solr/util/SolrCLI.java
<https://reviews.apache.org/r/28826/#comment106933>

    requestCallback is not used in this method. Is that intentional? Probably need to add the callback to line 432.


- Mike Drob


On Dec. 8, 2014, 10:25 p.m., Gregory Chanan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28826/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2014, 10:25 p.m.)
> 
> 
> Review request for lucene and Mark Miller.
> 
> 
> Repository: lucene
> 
> 
> Description
> -------
> 
> See: https://issues.apache.org/jira/browse/SOLR-6625
> 
> 
> Diffs
> -----
> 
>   trunk/solr/core/src/java/org/apache/solr/core/ConfigSolr.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/core/CoreContainer.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/update/StreamingSolrServers.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java 1643097 
>   trunk/solr/core/src/java/org/apache/solr/util/SolrCLI.java 1643097 
>   trunk/solr/core/src/test-files/solr/solr-httpcallback.xml PRE-CREATION 
>   trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java 1643097 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java 1643097 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServer.java 1643097 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientRequestCallback.java PRE-CREATION 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientRequestCallbackUtil.java PRE-CREATION 
>   trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrServer.java 1643097 
>   trunk/solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrServerTest.java 1643097 
>   trunk/solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServerTest.java 1643097 
> 
> Diff: https://reviews.apache.org/r/28826/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregory Chanan
> 
>