[GitHub] flink pull request #6032: [FLINK-9378][Table API & SQL] Improve TableExcepti...

[snuyanzin <gi...@git.apache.org>]

GitHub user snuyanzin opened a pull request:

    https://github.com/apache/flink/pull/6032

    [FLINK-9378][Table API & SQL] Improve TableException message with TypeName usage

    *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
    
    *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
    
    ## Contribution Checklist
    
      - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
      
      - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
      Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
    
      - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
      
      - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
    
      - Each pull request should address only one issue, not mix up code from multiple issues.
      
      - Each commit in the pull request has a meaningful commit message (including the JIRA id)
    
      - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
    
    
    **(The sections below can be removed for hotfixes of typos)**
    
    ## What is the purpose of the change
    
    *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
    
    
    ## Brief change log
    messages correction
    
    ## Verifying this change
    
    *(Please pick either of the following options)*
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): ( no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
      - The serializers: ( no)
      - The runtime per-record code paths (performance sensitive): ( no )
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: ( no )
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/snuyanzin/flink FLINK-9378_Improve_TableException_message_with_TypeName_usage

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6032.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6032
    
----
commit c896b92852e50eef158cb74df6cfcd8ad226333c
Author: snuyanzin <sn...@...>
Date:   2018-05-17T09:42:26Z

    use typename rather than simple name

----


---

[GitHub] flink issue #6032: [FLINK-9378][Table API & SQL] Improve TableException mess...

[twalthr <gi...@git.apache.org>]

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/6032
  
    Thanks for the PR @snuyanzin. However, I think we should not change the exception string but should improve the `org.apache.flink.api.common.typeinfo.SqlTimeTypeInfo#toString` method instead. Similar to `org.apache.flink.api.java.typeutils.GenericTypeInfo#toString`. The type class is too little information. The type information is necessary in most cases.


---

[GitHub] flink issue #6032: [FLINK-9378][Table API & SQL] Improve TableException mess...

[snuyanzin <gi...@git.apache.org>]

Github user snuyanzin commented on the issue:

    https://github.com/apache/flink/pull/6032
  
    @twalthr thank you for your review.
    To be honest thought about such approach indeed org.apache.flink.api.common.typeinfo.BasicTypeInfo#toString should be changed at least to fix case from here https://issues.apache.org/jira/browse/FLINK-9341?focusedCommentId=16475693&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16475693 .
    So I have 2 questions:
    1. is it ok to change public api behavior here (toString is public)?
    2. Should we go through all successors of org.apache.flink.api.common.typeinfo.TypeInformation and if its toString looks like clazz.getSimpleName than change it similar to org.apache.flink.api.java.typeutils.GenericTypeInfo#toString?
    
    could you please clarify it and than I could do required corrections


---