You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mark Struberg (JIRA)" <de...@myfaces.apache.org> on 2010/02/18 20:26:28 UTC
[jira] Created: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
BeanValidator throws Exception if external ExpressionLanguageFactory is being used
----------------------------------------------------------------------------------
Key: MYFACES-2565
URL: https://issues.apache.org/jira/browse/MYFACES-2565
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 2.0.0-beta
Reporter: Mark Struberg
Currently the BeanValidator has the following code:
if (_ExternalSpecifications.isUnifiedELAvailable())
{
//TODO: Implement when Unified EL for Java EE6 is available.
throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
}
I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
After that I get this rather unfunny Exception in the code above.
I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Jan-Kees van Andel (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan-Kees van Andel resolved MYFACES-2565.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-beta-3
It should work now, however I don't like the implementation. I need to resort to reflection if I want to use the ValueExpression.getValueReference() method, because the compile classpath contains two entries for ValueExpression: One in jsp-api-2.1 and one in el-api-2.2.
Someone please review the implementation...
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
> Assignee: Jan-Kees van Andel
> Fix For: 2.0.0-beta-3
>
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839292#action_12839292 ]
Jakob Korherr commented on MYFACES-2565:
----------------------------------------
I know it's not nice to have this replication (I hate it too), but it's the fasted solution under our condition.
Another possible solution would be to evaluate the fields from ExternalSpecifications in the ServletContextListener and store them under a specific key in the application map. This way we would get rid of our 3 implementations...
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
> Assignee: Jan-Kees van Andel
> Fix For: 2.0.0-beta-3
>
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Jan-Kees van Andel (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839290#action_12839290 ]
Jan-Kees van Andel commented on MYFACES-2565:
---------------------------------------------
Okay, but it's getting a bit nasty this way (copy-pasting this class 3 times, especially since it is getting more complex).
I assume we also need to work with Java access permissions turned on? Otherwise, we can do some reflection stuff, like:
- Putting all logic inside one class, let's say: javax.faces.validate._ExternalSpecifications
- Putting some kind of bridge classes in other packages, like:
package javax.faces.component;
class _ExternalSpecificationsBridge {
public boolean isUnifiedELAvailable() {
try {
Class c = Class.forName("javax.faces.validate._ExternalSpecifications");
Method m = c.getMethod("isUnifiedELAvailable");
m.setAccessible(true);
return Boolean.TRUE.equals(m.invoke());
} catch () { return false; }
}
}
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
> Assignee: Jan-Kees van Andel
> Fix For: 2.0.0-beta-3
>
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe reopened MYFACES-2565:
-------------------------------------
The patch committed here causes MYFACES-2605. It was added these dependencies:
<dependency>
<groupId>javax.validation</groupId>
<artifactId>validation-api</artifactId>
<version>1.0.CR3</version>
<optional>true</optional>
</dependency>
<dependency>
<groupId>javax.el</groupId>
<artifactId>el-api</artifactId>
<version>2.1.2-b05</version>
<optional>true</optional>
</dependency>
That's not good. The el-api dependency version should be 1.0, so we can't use code in a upper version.
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
> Assignee: Jan-Kees van Andel
> Fix For: 2.0.0-beta-3
>
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Jan-Kees van Andel (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835895#action_12835895 ]
Jan-Kees van Andel commented on MYFACES-2565:
---------------------------------------------
I put it there when implementing the first version of BeanValidator. The spec says the following:
http://java.sun.com/javaee/javaserverfaces/2.0/docs/api/javax/faces/validator/BeanValidator.html#validate%28javax.faces.context.FacesContext,%20javax.faces.component.UIComponent,%20java.lang.Object%29
Let valueExpression be the return from calling UIComponent.getValueExpression(java.lang.String) on the argument component, passing the literal string "value" (without the quotes) as an argument. If this application is running in an environment with a Unified EL Implementation for Java EE6 or later, obtain the ValueReference from valueExpression and let valueBaseClase be the return from calling ValueReference.getBase() and valueProperty be the return from calling ValueReference.getProperty(). If an earlier version of the Unified EL is present, use the appropriate methods to inspect valueExpression and derive values for valueBaseClass and valueProperty.
Back then, it was not possible to completely implement this method, because Unified EL was not available, so I put the TODO and Exception in. I assume we can now safely implement the remaining part.
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839287#action_12839287 ]
Jakob Korherr commented on MYFACES-2565:
----------------------------------------
ExternalSpecifications is also present in myfaces-impl (/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/util/ExternalSpecifications.java). Please also apply your changes there, Jan-Kees :)
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
> Assignee: Jan-Kees van Andel
> Fix For: 2.0.0-beta-3
>
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Jan-Kees van Andel (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839297#action_12839297 ]
Jan-Kees van Andel commented on MYFACES-2565:
---------------------------------------------
Separate issue created, see: MYFACES-2582
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
> Assignee: Jan-Kees van Andel
> Fix For: 2.0.0-beta-3
>
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839494#action_12839494 ]
Jakob Korherr commented on MYFACES-2565:
----------------------------------------
ExternalSpecifications on myfaces-impl must not be package private, because it is used in many packages of myfaces-impl! I'll change this.
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
> Assignee: Jan-Kees van Andel
> Fix For: 2.0.0-beta-3
>
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838612#action_12838612 ]
Mark Struberg commented on MYFACES-2565:
----------------------------------------
found an issue which may be related with commenting out the section above:
In some very rare cases I crash in
Class<?> valueBaseClass = valueReferenceWrapper.getBase().getClass();
because getBase() returns null.
I have no clue why this can happen, but may have something to do with my changes above.
So maybe the "TODO" is likely a bit more work ;)
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Jan-Kees van Andel (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838802#action_12838802 ]
Jan-Kees van Andel commented on MYFACES-2565:
---------------------------------------------
Just looking at the JavaDocs of BeanValidator#validate(), it looks like a null-check is missing.
"If ValueReference.getBase() return null, take no action and return."
I'll try to fix this issue (as well as the other BeanValidator related issues) this weekend, but it depends, since I'm a bit behind schedule after JSFDays...
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leonardo Uribe resolved MYFACES-2565.
-------------------------------------
Resolution: Fixed
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
> Assignee: Leonardo Uribe
> Fix For: 2.0.0-beta-3
>
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2565) BeanValidator throws Exception if
external ExpressionLanguageFactory is being used
Posted by "Mark Struberg (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838838#action_12838838 ]
Mark Struberg commented on MYFACES-2565:
----------------------------------------
oki, then it seems I at least locally patched it the right way already -txs.
And don't worry, I think JSFdays was a big boost again in terms of ideas, knowledge and of course motivation which will overcompensate loosing those 3 days easily ;)
> BeanValidator throws Exception if external ExpressionLanguageFactory is being used
> ----------------------------------------------------------------------------------
>
> Key: MYFACES-2565
> URL: https://issues.apache.org/jira/browse/MYFACES-2565
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.0.0-beta
> Reporter: Mark Struberg
>
> Currently the BeanValidator has the following code:
> if (_ExternalSpecifications.isUnifiedELAvailable())
> {
> //TODO: Implement when Unified EL for Java EE6 is available.
> throw new FacesException("Unified EL for Java EE6 support is not yet implemented");
> }
> I'm using EL-2.2 in MyFaces-2.0.0-SNAPSHOT and now switched from using facelets-1.1.15.B1 to the built-in facelets-2.
> After that I get this rather unfunny Exception in the code above.
> I tried to remove this condition in BeanValidator and so far all works well. Afaik the new EL-2.1 interface should be backward compatible to the EL of JSF-2.1, isn't?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.