[GitHub] [kafka] vvcephei commented on a change in pull request #8902: KAFKA-10179: Pass correct changelog topic to state serdes

[GitBox <gi...@apache.org>]

vvcephei commented on a change in pull request #8902:
URL: https://github.com/apache/kafka/pull/8902#discussion_r450979875



##########
File path: streams/src/test/java/org/apache/kafka/test/InternalMockProcessorContext.java
##########
@@ -193,6 +194,11 @@ public InternalMockProcessorContext(final File stateDir,
         this.metrics().setRocksDBMetricsRecordingTrigger(new RocksDBMetricsRecordingTrigger(new SystemTime()));
     }
 
+    @Override
+    protected StateManagerStub stateManager() {

Review comment:
       Should this be:
   
   ```suggestion
       protected StateManager stateManager() {
   ```
   
   ?

##########
File path: streams/src/test/java/org/apache/kafka/test/NoOpProcessorContext.java
##########
@@ -55,6 +58,11 @@ private static StreamsConfig streamsConfig() {
         return new StreamsConfig(props);
     }
 
+    @Override
+    protected StateManagerStub stateManager() {

Review comment:
       and here?
   ```suggestion
       protected StateManager stateManager() {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org