[GitHub] [maven-plugin-tools] slawekjaranowski commented on a change in pull request #58: [MPLUGIN-386] Exclude maven-archiver and maven-jxr from warning

[GitBox <gi...@apache.org>]

slawekjaranowski commented on a change in pull request #58:
URL: https://github.com/apache/maven-plugin-tools/pull/58#discussion_r775010321



##########
File path: maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java
##########
@@ -327,8 +327,11 @@ static String getDefaultGoalPrefix( MavenProject project )
 
         for ( Artifact dependency : project.getArtifacts() )
         {
+            // maven-archiver and maven-jxr are really in wrong groupId
             if ( "org.apache.maven".equals( dependency.getGroupId() )
                 && dependency.getArtifactId().startsWith( "maven-" )
+                && !dependency.getArtifactId().equals( "maven-archiver" )
+                && !dependency.getArtifactId().equals( "maven-jxr" )

Review comment:
       Maybe put excludes names in some list to simplify expression ... 
   will be easier add next exclude

##########
File path: maven-plugin-plugin/src/it/mplugin-370-maven-deps-scope-bad/pom.xml
##########
@@ -38,6 +38,12 @@ under the License.
   </properties>
 
   <dependencies>
+    <dependency>
+      <groupId>org.apache.maven</groupId>
+      <artifactId>maven-jxr</artifactId>
+      <version>3.1.1</version>
+      <scope>compile</scope>
+    </dependency>

Review comment:
       There are no assertions for it ... so here is no need




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org