You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/01/13 14:18:06 UTC
Re: Review Request 41438: Added documentation on using network proxy
for mesos fetcher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review114194
-----------------------------------------------------------
docs/fetcher.md (line 226)
<https://reviews.apache.org/r/41438/#comment175013>
s/mesos/Mesos (or otherwise consistent with the rest of the file)
docs/fetcher.md (line 231)
<https://reviews.apache.org/r/41438/#comment175015>
does protocol here has the same limitation as below in line 241 (socks4/socks5/http/https)?
docs/fetcher.md (line 232)
<https://reviews.apache.org/r/41438/#comment175014>
s/uri/URI or consistent with the rest of the file...
docs/fetcher.md (line 260)
<https://reviews.apache.org/r/41438/#comment175012>
Any reason for two blank lines here?
- Joerg Schad
On Dec. 24, 2015, 1:22 p.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2015, 1:22 p.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation on using network proxy for mesos fetcher
>
>
> Diffs
> -----
>
> docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84
>
> Diff: https://reviews.apache.org/r/41438/diff/
>
>
> Testing
> -------
>
> - Set `https_proxy=http://localhost:3128` (a local squid server) in `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task with a `https://` uri, and through the following sysdig command I can see there is data exchanging between mesos-fetcher process and port 3128.
>
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
>
> - Stop the local squid server, try to restart the marathon task, the task would fail repeatly, from slave logs there are error messages that fetcher failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-0000' failed to start: Failed to fetch all URIs for container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
>
> - Restart the squid server, the task would start without a problem.
>
>
> Thanks,
>
> Shuai Lin
>
>
Re: Review Request 41438: Added documentation on using network proxy
for mesos fetcher
Posted by Bernd Mathiske <be...@mesosphere.io>.
> On Jan. 13, 2016, 5:18 a.m., Joerg Schad wrote:
> > docs/fetcher.md, line 231
> > <https://reviews.apache.org/r/41438/diff/4/?file=1176098#file1176098line231>
> >
> > does protocol here has the same limitation as below in line 241 (socks4/socks5/http/https)?
Yes. I made that explicit now.
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review114194
-----------------------------------------------------------
On Dec. 24, 2015, 5:22 a.m., Shuai Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2015, 5:22 a.m.)
>
>
> Review request for mesos and Bernd Mathiske.
>
>
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation on using network proxy for mesos fetcher
>
>
> Diffs
> -----
>
> docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84
>
> Diff: https://reviews.apache.org/r/41438/diff/
>
>
> Testing
> -------
>
> - Set `https_proxy=http://localhost:3128` (a local squid server) in `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task with a `https://` uri, and through the following sysdig command I can see there is data exchanging between mesos-fetcher process and port 3128.
>
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
>
> - Stop the local squid server, try to restart the marathon task, the task would fail repeatly, from slave logs there are error messages that fetcher failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-0000' failed to start: Failed to fetch all URIs for container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
>
> - Restart the squid server, the task would start without a problem.
>
>
> Thanks,
>
> Shuai Lin
>
>