You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/11 09:34:12 UTC
[GitHub] [shardingsphere] zhfeng opened a new pull request, #23504: Upgrade antlr4 to 4.10.1
zhfeng opened a new pull request, #23504:
URL: https://github.com/apache/shardingsphere/pull/23504
Fixes https://github.com/quarkiverse/quarkus-shardingsphere-jdbc/issues/84.
Changes proposed in this pull request:
- Bump antlr4 to `4.10.1` which should be helpful to `quarkus-shardingshpere-jdbc`.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #23504: Upgrade antlr4 to 4.10.1
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #23504:
URL: https://github.com/apache/shardingsphere/pull/23504#issuecomment-1378516181
Duplicate with #20008.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhfeng closed pull request #23504: Upgrade antlr4 to 4.10.1
Posted by GitBox <gi...@apache.org>.
zhfeng closed pull request #23504: Upgrade antlr4 to 4.10.1
URL: https://github.com/apache/shardingsphere/pull/23504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhfeng commented on pull request #23504: Upgrade antlr4 to 4.10.1
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #23504:
URL: https://github.com/apache/shardingsphere/pull/23504#issuecomment-1378517992
Yeah, I'm sorry to miss the similar PR. Thanks @TeslaCN !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhfeng commented on pull request #23504: Upgrade antlr4 to 4.10.1
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #23504:
URL: https://github.com/apache/shardingsphere/pull/23504#issuecomment-1378481806
Hmm, it looks like `antlr-4.10.1` is only for JDK > 11. So is there any plan for `sharding-sphere` to drop support of `JDK 8`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org