You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/10/23 01:02:10 UTC
[GitHub] [incubator-mxnet] ChaiBapchya opened a new pull request #16585: C
Api for simplebind, fix comment for trigoops, add atol to assert
ChaiBapchya opened a new pull request #16585: C Api for simplebind, fix comment for trigoops, add atol to assert
URL: https://github.com/apache/incubator-mxnet/pull/16585
## Description ##
Simple_bind (used in Symbolic mode) used to fail for Large tensor (esp when individual dimension was of size > `2**32`
PR https://github.com/apache/incubator-mxnet/pull/16497 introduces large vector tests
test_regression for Logistic and Linear regression has been written for symbolic mode
And it fails otherwise. This PR will fix it.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- [ ] Code is well-documented:
- [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] M include/mxnet/c_api.h
- [ ] M python/mxnet/symbol/symbol.py
- [ ] M src/c_api/c_api_executor.cc
- [ ] M tests/nightly/test_large_array.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services