You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "stephenkittelson (via GitHub)" <gi...@apache.org> on 2023/10/09 18:14:31 UTC
[PR] AVRO-2956: [java] add reserved word escape character to the end of reserved and contextual keywords [avro]
stephenkittelson opened a new pull request, #2544:
URL: https://github.com/apache/avro/pull/2544
## What is the purpose of the change
This pull requests fixes deserialization of schemas with Java reserved and contextual keywords as field names which fixes AVRO-2956.
## Verifying this change
This change can be verified with the added unit tests that validate deserialization adds the reserved word escape character to the end of class names that match reserved words or contextual keywords.
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-2956: [java] add reserved word escape character to the end of reserved and contextual keywords [avro]
Posted by "stephenkittelson (via GitHub)" <gi...@apache.org>.
stephenkittelson commented on PR #2544:
URL: https://github.com/apache/avro/pull/2544#issuecomment-1791317704
Looks like the Python check failed due to failure to download bzip which seems unrelated to my changes. I went ahead and sync'ed my branch with main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-2956: [java] add reserved word escape character to the end of reserved and contextual keywords [avro]
Posted by "stephenkittelson (via GitHub)" <gi...@apache.org>.
stephenkittelson closed pull request #2544: AVRO-2956: [java] add reserved word escape character to the end of reserved and contextual keywords
URL: https://github.com/apache/avro/pull/2544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-2956: [java] add reserved word escape character to the end of reserved and contextual keywords [avro]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #2544:
URL: https://github.com/apache/avro/pull/2544#issuecomment-1871165852
@stephenkittelson Thanks, anyway, thank you for working on this! 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-2956: [java] add reserved word escape character to the end of reserved and contextual keywords [avro]
Posted by "stephenkittelson (via GitHub)" <gi...@apache.org>.
stephenkittelson commented on PR #2544:
URL: https://github.com/apache/avro/pull/2544#issuecomment-1866845521
> @stephenkittelson can you fix the conflicts?
Looks like Kyle Carter's PR 1527 fixed the same issue this PR was going to fix, so this PR is no longer necessary. Thanks for taking a look Fokko!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-2956: [java] add reserved word escape character to the end of reserved and contextual keywords [avro]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #2544:
URL: https://github.com/apache/avro/pull/2544#issuecomment-1866260755
@stephenkittelson can you fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org