You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/08/28 12:49:33 UTC
[GitHub] [echarts] sebbASF opened a new issue #15620: Site defaults to Chinese
sebbASF opened a new issue #15620:
URL: https://github.com/apache/echarts/issues/15620
### Version
Current
### Steps to reproduce
Browse to https://echarts.apache.org/
### What is expected?
Site should redirect based on request header such as accept-language
### What is actually happening?
Unconditional redirect to Chinese site
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sebbASF commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-907772216
Here is some info on setting up the Apache server to handle different languages
https://httpd.apache.org/docs/2.4/content-negotiation.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang edited a comment on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-907710414
We are using `navigator.language` and `navigator.userLanguage` to redirect. Do you mind giving us your value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-908759646
@sebbASF I changed redirection from 301 moved permanently to 302 found. It should work properly now. Sorry for the mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sebbASF commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909056007
It does not always work for curl:
$ curl -I -H "Accept-language: en-GB,en;q=0.9" echarts.apache.org
HTTP/1.1 302 Found
Server: Apache
Location: https://echarts.apache.org/zh/index.html
Then a few minutes later:
$ curl -I -H "Accept-language: en-GB,en;q=0.9" echarts.apache.org
HTTP/1.1 302 Found
Server: Apache
Location: https://echarts.apache.org/en/index.html
I'm not 100% sure it always works for browsers; will have to see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart edited a comment on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909066723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909066723
It seems the redirection will be cached if we request the same URL even if `Accept-Language` is changed.
It works well if we add a query parameter, for example, `echarts.apache.org?v=1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sebbASF commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909056007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909066723
It seems the redirection will be cached if we request the same URL even if `Accept-Language` is changed.
It works well if we add a query parameter, for example, `echarts.apache.org?v=1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-922428537
@sebbASF Hi, we've fixed the redirection issue. Here is the current behavior,
<img src="https://user-images.githubusercontent.com/26999792/133919101-4ae5cd2b-0bfd-4ff7-9889-6727a39af16d.png" width="500">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sebbASF commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-907765327
Those look like Javascript variables. It should not be necessary to enable JavaScript for the redirect to work.
User agents such as browsers send a header such as mine:
accept-language: en-GB,en;q=0.9
AFAIK, if the HTTP server and the page paths are set up correctly, it should redirect automatically without needing Javascript.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-916590964
@plainheart has probably made some updates about the cache policy. Waiting for him to give a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sebbASF commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909056007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-907710414
We are using `navigator.userLanguage` to redirect. Do you mind giving us your value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-907982057
It seems to do with our caching settings. We are working on this. Thanks for reporting!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909066723
It seems the redirection will be cached if we request the same URL even if `Accept-Language` is changed.
It works well if we add a query parameter, for example, `echarts.apache.org?v=1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart edited a comment on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909066723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] sebbASF commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
sebbASF commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909086448
Yes, but adding a parameter only works if it is changed from the previous one, and you can't expect users to do that.
The cache key needs to include accept-language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-908759646
@sebbASF I changed redirection from 301 moved permanently to 302 found. It should work properly now. Sorry for the mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart edited a comment on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-909066723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on issue #15620: Site defaults to Chinese
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #15620:
URL: https://github.com/apache/echarts/issues/15620#issuecomment-907622083
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that it contains **a minimum reproducible demo** and necessary **images** to illustrate. Otherwise, our committers will ask you to do so.
*A minimum reproducible demo* should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster.
You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
If you are interested in the project, you may also subscribe to our [mailing list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org