You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "serrislew (via GitHub)" <gi...@apache.org> on 2024/08/05 23:19:26 UTC
[PR] Disable mptcp if logging is disabled [trafficserver]
serrislew opened a new pull request, #11651:
URL: https://github.com/apache/trafficserver/pull/11651
Logging for mptcp relies on specific libraries to be available. We shouldn't enable mptcp if we can't log it properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable mptcp if proper header files are not available [trafficserver]
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew merged PR #11651:
URL: https://github.com/apache/trafficserver/pull/11651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable mptcp if proper header files are not available [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11651:
URL: https://github.com/apache/trafficserver/pull/11651#issuecomment-2299062798
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable mptcp if logging is disabled [trafficserver]
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew commented on code in PR #11651:
URL: https://github.com/apache/trafficserver/pull/11651#discussion_r1704737839
##########
src/records/RecHttp.cc:
##########
@@ -98,11 +98,13 @@ mptcp_supported()
ats_scoped_fd fd(::open("/proc/sys/net/mptcp/enabled", O_RDONLY));
Review Comment:
You're right. I will include it in the conditional, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disable mptcp if logging is disabled [trafficserver]
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on code in PR #11651:
URL: https://github.com/apache/trafficserver/pull/11651#discussion_r1704724804
##########
src/records/RecHttp.cc:
##########
@@ -98,11 +98,13 @@ mptcp_supported()
ats_scoped_fd fd(::open("/proc/sys/net/mptcp/enabled", O_RDONLY));
Review Comment:
Do we need to try to open this regardless of the conditions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org