You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/15 06:39:25 UTC
[GitHub] [pulsar] poorbarcode opened a new pull request, #16617: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack store
poorbarcode opened a new pull request, #16617:
URL: https://github.com/apache/pulsar/pull/16617
Master Issue: #15370
### Motivation
see #15370
### Modifications
I will complete proposal #15370 with these pull requests( *current pull request is the step-2* ):
1. Write the batch transaction log handler: `TxnLogBufferedWriter`
2. Configuration changes and protocol changes.
3. `MLPendingAckStore` and `MLTransactionLogImpl` support reading of batched logs.
4. `MLPendingAckStore` and `MLTransactionLogImpl` support the writing of batched logs and support dynamic configuration.
5. Append admin API for transaction batch log and docs( admin and configuration doc ).
6. Append metrics support for transaction batch log.
### Documentation
- [ ] `doc-required`
- [x] `doc-not-needed`
- [ ] `doc`
- [ ] `doc-complete`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16617: [improve] [txn] [PIP-160] Protocol changes and Configuration changes for transaction batch log
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#issuecomment-1185286499
> @poorbarcode Please update the PR title as the PR really changed.
Already Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16617: [improve] [txn] [PIP-160] Protocol changes and configuration changes for transaction batch log
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#issuecomment-1186221431
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16617: [improve] [txn] [PIP-160] Protocol changes and Configuration changes for transaction batch log
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on code in PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#discussion_r921922418
##########
conf/broker.conf:
##########
@@ -1535,4 +1535,28 @@ managedLedgerMaxUnackedRangesToPersistInZooKeeper=-1
# If enabled, the maximum "acknowledgment holes" will not be limited and "acknowledgment holes" are stored in
# multiple entries.
-persistentUnackedRangesWithMultipleEntriesEnabled=false
\ No newline at end of file
+persistentUnackedRangesWithMultipleEntriesEnabled=false
+
+# Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched record and
+# persist into a single BK entry. This will make Pulsar transactions work more efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionLogBatchedWriteEnabled = false;
+# If enabled the feature that transaction log batch, this attribute means maximum log records count in a batch.
+transactionLogBatchedWriteMaxRecords= 512;
+# If enabled the feature that transaction log batch, this attribute means bytes size in a batch.
+transactionLogBatchedWriteMaxSize= 1024 * 1024 * 4;
+# If enabled the feature that transaction log batch, this attribute means maximum wait time(in millis) for the first
+# record in a batch
+transactionLogBatchedWriteMaxDelayInMillis= 1;
+# Provide a mechanism allowing the Pending Ack Store to aggregate multiple records into a batched record and persist
+# into a single BK entry. This will make Pulsar transactions work more efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionPendingAckBatchedWriteEnabled = false;
+# If enabled the feature that transaction pending ack log batch, this attribute means maximum log records count in a
+# batch.
+transactionPendingAckBatchedWriteMaxRecords= 512;
+# If enabled the feature that transaction pending ack log batch, this attribute means bytes size in a batch.
+transactionPendingAckBatchedWriteMaxSize= 1024 * 1024 * 4;
+# If enabled the feature that transaction pending ack log batch, this attribute means maximum wait time(in millis) for
+# the first record in a batch.
+transactionPendingAckBatchedWriteMaxDelayInMillis= 1;
Review Comment:
Already fixed.
##########
conf/broker.conf:
##########
@@ -1535,4 +1535,28 @@ managedLedgerMaxUnackedRangesToPersistInZooKeeper=-1
# If enabled, the maximum "acknowledgment holes" will not be limited and "acknowledgment holes" are stored in
# multiple entries.
-persistentUnackedRangesWithMultipleEntriesEnabled=false
\ No newline at end of file
+persistentUnackedRangesWithMultipleEntriesEnabled=false
+
+# Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched record and
+# persist into a single BK entry. This will make Pulsar transactions work more efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionLogBatchedWriteEnabled = false;
Review Comment:
Already fixed.
##########
conf/broker.conf:
##########
@@ -1535,4 +1535,28 @@ managedLedgerMaxUnackedRangesToPersistInZooKeeper=-1
# If enabled, the maximum "acknowledgment holes" will not be limited and "acknowledgment holes" are stored in
# multiple entries.
-persistentUnackedRangesWithMultipleEntriesEnabled=false
\ No newline at end of file
+persistentUnackedRangesWithMultipleEntriesEnabled=false
+
+# Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched record and
+# persist into a single BK entry. This will make Pulsar transactions work more efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionLogBatchedWriteEnabled = false;
+# If enabled the feature that transaction log batch, this attribute means maximum log records count in a batch.
+transactionLogBatchedWriteMaxRecords= 512;
+# If enabled the feature that transaction log batch, this attribute means bytes size in a batch.
+transactionLogBatchedWriteMaxSize= 1024 * 1024 * 4;
Review Comment:
Already fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16617: [improve] [txn] [PIP-160] Protocol changes and configuration changes for transaction batch log
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#issuecomment-1185326825
> Please add an unit test to make sure the configuration is really work and make sure the default value is expected.
This is a good way to solve the errors caused by carelessness. Thanks.
Already fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #16617: [improve] [txn] [PIP-160] Protocol changes and configuration changes for transaction batch log
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#discussion_r921993382
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2653,6 +2653,67 @@ public class ServiceConfiguration implements PulsarConfiguration {
)
private long transactionPendingAckLogIndexMinLag = 500L;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched"
+ + " record and persist into a single BK entry. This will make Pulsar transactions work more"
+ + " efficiently, aka batched log. see: https://github.com/apache/pulsar/issues/15370. Default false"
+ )
+ private boolean transactionLogBatchedWriteEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum log records count"
+ + " in a batch, default 512."
+ )
+ private int transactionLogBatchedWriteMaxRecords = 512;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means bytes size in a"
+ + " batch, default 4m."
+ )
+ private int transactionLogBatchedWriteMaxSize = 1024 * 1024 * 4;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum wait time(in millis)"
+ + " for the first record in a batch, default 1."
Review Comment:
```suggestion
+ " for the first record in a batch, default 1 millisecond."
```
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2653,6 +2653,67 @@ public class ServiceConfiguration implements PulsarConfiguration {
)
private long transactionPendingAckLogIndexMinLag = 500L;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched"
+ + " record and persist into a single BK entry. This will make Pulsar transactions work more"
+ + " efficiently, aka batched log. see: https://github.com/apache/pulsar/issues/15370. Default false"
+ )
+ private boolean transactionLogBatchedWriteEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum log records count"
+ + " in a batch, default 512."
+ )
+ private int transactionLogBatchedWriteMaxRecords = 512;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means bytes size in a"
+ + " batch, default 4m."
+ )
+ private int transactionLogBatchedWriteMaxSize = 1024 * 1024 * 4;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum wait time(in millis)"
+ + " for the first record in a batch, default 1."
+ )
+ private int transactionLogBatchedWriteMaxDelayInMillis = 1;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Provide a mechanism allowing the transaction pending ack Log Store to aggregate multiple records"
+ + " into a batched record and persist into a single BK entry. This will make Pulsar transactions"
+ + " work more efficiently, aka batched log. see: https://github.com/apache/pulsar/issues/15370."
+ + " Default false."
+ )
+ private boolean transactionPendingAckBatchedWriteEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum log records count"
+ + " in a batch, default 512."
+ )
+ private int transactionPendingAckBatchedWriteMaxRecords = 512;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction pending ack log batch, this attribute means bytes size in"
+ + " a batch, default 4m."
+ )
+ private int transactionPendingAckBatchedWriteMaxSize = 1024 * 1024 * 4;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction pending ack log batch, this attribute means maximum wait"
+ + " time(in millis) for the first record in a batch, default 1."
Review Comment:
```suggestion
+ " time(in millisecond) for the first record in a batch, default 1 millisecond."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16617: [improve] [txn] [PIP-160] Protocol changes and configuration changes for transaction batch log
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#issuecomment-1186192684
> LGTM, Another question: Should we add this configuration in standalone.conf?
Already fixed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #16617: [improve] [txn] [PIP-160] Protocol changes and configuration changes for transaction batch log
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#issuecomment-1188503209
Hi, @poorbarcode, will you add or update relevant docs in a follow-up PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16617: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack store
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#discussion_r921911428
##########
conf/broker.conf:
##########
@@ -1535,4 +1535,28 @@ managedLedgerMaxUnackedRangesToPersistInZooKeeper=-1
# If enabled, the maximum "acknowledgment holes" will not be limited and "acknowledgment holes" are stored in
# multiple entries.
-persistentUnackedRangesWithMultipleEntriesEnabled=false
\ No newline at end of file
+persistentUnackedRangesWithMultipleEntriesEnabled=false
+
+# Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched record and
+# persist into a single BK entry. This will make Pulsar transactions work more efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionLogBatchedWriteEnabled = false;
Review Comment:
```suggestion
transactionLogBatchedWriteEnabled=false;
```
Please check all.
##########
conf/broker.conf:
##########
@@ -1535,4 +1535,28 @@ managedLedgerMaxUnackedRangesToPersistInZooKeeper=-1
# If enabled, the maximum "acknowledgment holes" will not be limited and "acknowledgment holes" are stored in
# multiple entries.
-persistentUnackedRangesWithMultipleEntriesEnabled=false
\ No newline at end of file
+persistentUnackedRangesWithMultipleEntriesEnabled=false
+
+# Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched record and
+# persist into a single BK entry. This will make Pulsar transactions work more efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionLogBatchedWriteEnabled = false;
+# If enabled the feature that transaction log batch, this attribute means maximum log records count in a batch.
+transactionLogBatchedWriteMaxRecords= 512;
+# If enabled the feature that transaction log batch, this attribute means bytes size in a batch.
+transactionLogBatchedWriteMaxSize= 1024 * 1024 * 4;
Review Comment:
I think we can't user `1024 * 1024 * 4` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] congbobo184 commented on a diff in pull request #16617: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack store
Posted by GitBox <gi...@apache.org>.
congbobo184 commented on code in PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#discussion_r921909255
##########
conf/broker.conf:
##########
@@ -1535,4 +1535,28 @@ managedLedgerMaxUnackedRangesToPersistInZooKeeper=-1
# If enabled, the maximum "acknowledgment holes" will not be limited and "acknowledgment holes" are stored in
# multiple entries.
-persistentUnackedRangesWithMultipleEntriesEnabled=false
\ No newline at end of file
+persistentUnackedRangesWithMultipleEntriesEnabled=false
+
+# Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched record and
+# persist into a single BK entry. This will make Pulsar transactions work more efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionLogBatchedWriteEnabled = false;
+# If enabled the feature that transaction log batch, this attribute means maximum log records count in a batch.
+transactionLogBatchedWriteMaxRecords= 512;
+# If enabled the feature that transaction log batch, this attribute means bytes size in a batch.
+transactionLogBatchedWriteMaxSize= 1024 * 1024 * 4;
+# If enabled the feature that transaction log batch, this attribute means maximum wait time(in millis) for the first
+# record in a batch
+transactionLogBatchedWriteMaxDelayInMillis= 1;
+# Provide a mechanism allowing the Pending Ack Store to aggregate multiple records into a batched record and persist
+# into a single BK entry. This will make Pulsar transactions work more efficiently, aka batched log.
+# see: https://github.com/apache/pulsar/issues/15370
+transactionPendingAckBatchedWriteEnabled = false;
+# If enabled the feature that transaction pending ack log batch, this attribute means maximum log records count in a
+# batch.
+transactionPendingAckBatchedWriteMaxRecords= 512;
+# If enabled the feature that transaction pending ack log batch, this attribute means bytes size in a batch.
+transactionPendingAckBatchedWriteMaxSize= 1024 * 1024 * 4;
+# If enabled the feature that transaction pending ack log batch, this attribute means maximum wait time(in millis) for
+# the first record in a batch.
+transactionPendingAckBatchedWriteMaxDelayInMillis= 1;
Review Comment:
move to
under https://github.com/apache/pulsar/blob/cfabdf88ea14eae3cc7105080d2d7531539b40e2/conf/broker.conf#L1437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou merged pull request #16617: [improve] [txn] [PIP-160] Protocol changes and configuration changes for transaction batch log
Posted by GitBox <gi...@apache.org>.
liangyepianzhou merged PR #16617:
URL: https://github.com/apache/pulsar/pull/16617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on a diff in pull request #16617: [improve] [txn] [PIP-160] Protocol changes and configuration changes for transaction batch log
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on code in PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#discussion_r922006277
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2653,6 +2653,67 @@ public class ServiceConfiguration implements PulsarConfiguration {
)
private long transactionPendingAckLogIndexMinLag = 500L;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched"
+ + " record and persist into a single BK entry. This will make Pulsar transactions work more"
+ + " efficiently, aka batched log. see: https://github.com/apache/pulsar/issues/15370. Default false"
+ )
+ private boolean transactionLogBatchedWriteEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum log records count"
+ + " in a batch, default 512."
+ )
+ private int transactionLogBatchedWriteMaxRecords = 512;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means bytes size in a"
+ + " batch, default 4m."
+ )
+ private int transactionLogBatchedWriteMaxSize = 1024 * 1024 * 4;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum wait time(in millis)"
+ + " for the first record in a batch, default 1."
Review Comment:
Already fixed.
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2653,6 +2653,67 @@ public class ServiceConfiguration implements PulsarConfiguration {
)
private long transactionPendingAckLogIndexMinLag = 500L;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Provide a mechanism allowing the Transaction Log Store to aggregate multiple records into a batched"
+ + " record and persist into a single BK entry. This will make Pulsar transactions work more"
+ + " efficiently, aka batched log. see: https://github.com/apache/pulsar/issues/15370. Default false"
+ )
+ private boolean transactionLogBatchedWriteEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum log records count"
+ + " in a batch, default 512."
+ )
+ private int transactionLogBatchedWriteMaxRecords = 512;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means bytes size in a"
+ + " batch, default 4m."
+ )
+ private int transactionLogBatchedWriteMaxSize = 1024 * 1024 * 4;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum wait time(in millis)"
+ + " for the first record in a batch, default 1."
+ )
+ private int transactionLogBatchedWriteMaxDelayInMillis = 1;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Provide a mechanism allowing the transaction pending ack Log Store to aggregate multiple records"
+ + " into a batched record and persist into a single BK entry. This will make Pulsar transactions"
+ + " work more efficiently, aka batched log. see: https://github.com/apache/pulsar/issues/15370."
+ + " Default false."
+ )
+ private boolean transactionPendingAckBatchedWriteEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction log batch, this attribute means maximum log records count"
+ + " in a batch, default 512."
+ )
+ private int transactionPendingAckBatchedWriteMaxRecords = 512;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction pending ack log batch, this attribute means bytes size in"
+ + " a batch, default 4m."
+ )
+ private int transactionPendingAckBatchedWriteMaxSize = 1024 * 1024 * 4;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ doc = "If enabled the feature that transaction pending ack log batch, this attribute means maximum wait"
+ + " time(in millis) for the first record in a batch, default 1."
Review Comment:
Already fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16617: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack store
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#issuecomment-1185229466
@liangyepianzhou @congbobo184 @codelipenghui Could you take a look, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #16617: [improve] [txn] [PIP-160] Make transactions work more efficiently by aggregation operation for transaction log and pending ack store
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #16617:
URL: https://github.com/apache/pulsar/pull/16617#issuecomment-1185281627
@poorbarcode Please update the PR title as the PR really changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org