You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 19:29:07 UTC

[GitHub] [airflow] nisarg1499 opened a new issue #15974: Constraints support in DockerOperator

nisarg1499 opened a new issue #15974:
URL: https://github.com/apache/airflow/issues/15974


   **Description**
   In the current DockerSwarmOperator, there is no parameter of network and constraint. It will create a container in a new network and without constraints of worker node or manager node. Now, there is support of network in DockerOperator, but constraints is not supported. 
   
   Use case : 
   
   **Use case / motivation**
   If some user has an existing swarm network and want to create a service with network and constraints specified, then this support will be useful.
   
   Final output should be that a user can start a service with network and constraints(worker or manager) specified in existing swarm network.
   
   **Are you willing to submit a PR?**
   Yes
    
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nisarg1499 commented on issue #15974: Constraints support in DockerOperator

Posted by GitBox <gi...@apache.org>.
nisarg1499 commented on issue #15974:
URL: https://github.com/apache/airflow/issues/15974#issuecomment-975989903


   > @nisarg1499 are you still working on this issue?
   
   Hey @eladkal Currently I am not working on this due to hectic schedule. But I know the solution as I have worked on this and I was planning to complete that in December. But if in between someone wants to work on this, then feel free to take it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Bowrna commented on issue #15974: Constraints support in DockerOperator

Posted by GitBox <gi...@apache.org>.
Bowrna commented on issue #15974:
URL: https://github.com/apache/airflow/issues/15974#issuecomment-1060390356


   I am willing to try fixing this issue :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Bowrna commented on issue #15974: Constraints support in DockerOperator

Posted by GitBox <gi...@apache.org>.
Bowrna commented on issue #15974:
URL: https://github.com/apache/airflow/issues/15974#issuecomment-1067529912


   Could we close this issue as suggested in PR https://github.com/apache/airflow/pull/22217 @eladkal?
   
   We already have documentation for this part and you can refer to the below part to check about network and constraints.
   
   ![image](https://user-images.githubusercontent.com/10162465/158301569-861414f1-c86b-466a-9dba-a3cd8f6fdd31.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] nisarg1499 commented on issue #15974: Constraints support in DockerOperator

Posted by GitBox <gi...@apache.org>.
nisarg1499 commented on issue #15974:
URL: https://github.com/apache/airflow/issues/15974#issuecomment-845416893


   I am working on this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #15974: Constraints support in DockerOperator

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15974:
URL: https://github.com/apache/airflow/issues/15974#issuecomment-975487485


   @nisarg1499 are you still working on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] eladkal commented on issue #15974: Constraints support in DockerOperator

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15974:
URL: https://github.com/apache/airflow/issues/15974#issuecomment-1060618394


   @Bowrna assgined


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Bowrna commented on issue #15974: Constraints support in DockerOperator

Posted by GitBox <gi...@apache.org>.
Bowrna commented on issue #15974:
URL: https://github.com/apache/airflow/issues/15974#issuecomment-1064991960


   https://github.com/apache/airflow/blob/e63f6e36d14a8cd2462e80f26fb4809ab8698380/airflow/providers/docker/operators/docker_swarm.py#L93-L113
   
   In docker swarm, we have the option to pass network and placement. The type `placement` is a type of dict and accepts constraint as a parameter.  The current code of DockerSwarmOperator looks like having support for network and constraint. Maybe we can improve the documentation for better understanding. 
   
   ```
   placement= Placement(constraints=['node.role == "manager"'])
   ```
   I didn't try the above code, but something in this way is supported to pass constraint
   
   If I am missing to understand any part, please explain
   
   In DockerOperator, when you mean by constraint, do you mean the resource constraint? If yes, there is support for cpu_shares, mem_limit. If it's something different, could you explain?
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #15974: Constraints support in DockerOperator

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #15974:
URL: https://github.com/apache/airflow/issues/15974#issuecomment-845415664


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org