You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Anton Katernoga (JIRA)" <ji...@codehaus.org> on 2007/02/23 17:06:27 UTC
[jira] Created: (CONTINUUM-1183) Perforce problem: incorrect client
spec is used
Perforce problem: incorrect client spec is used
-----------------------------------------------
Key: CONTINUUM-1183
URL: http://jira.codehaus.org/browse/CONTINUUM-1183
Project: Continuum
Issue Type: Bug
Components: SCM
Affects Versions: 1.0.3
Reporter: Anton Katernoga
Attachments: patch.p4.txt
I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-281) Perforce problem: incorrect client spec
is used
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88570 ]
Mike Perham commented on SCM-281:
---------------------------------
Does Continuum have a way to set the environment variables for a build before the build is executed? If yes, you should be setting the clientspec system property to the proper value for each build beforehand. That patch is unacceptable because it removes the ability to specify the clientspec as a system property.
> Perforce problem: incorrect client spec is used
> -----------------------------------------------
>
> Key: SCM-281
> URL: http://jira.codehaus.org/browse/SCM-281
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-4
> Reporter: Anton Katernoga
> Attachments: patch.p4.txt
>
>
> I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-281) Perforce problem: incorrect client spec
is used
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88685 ]
Emmanuel Venisse commented on SCM-281:
--------------------------------------
I removed the maven.scm.perforce.clientspec.name system property in continuum so the correct clientspec name used should be ok now.
Anton, can you test it?
> Perforce problem: incorrect client spec is used
> -----------------------------------------------
>
> Key: SCM-281
> URL: http://jira.codehaus.org/browse/SCM-281
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-4
> Reporter: Anton Katernoga
> Assigned To: Mike Perham
> Attachments: patch.p4.txt
>
>
> I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-281) Perforce problem: incorrect client spec
is used
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_89740 ]
Emmanuel Venisse commented on SCM-281:
--------------------------------------
Anton, do you have any news?
> Perforce problem: incorrect client spec is used
> -----------------------------------------------
>
> Key: SCM-281
> URL: http://jira.codehaus.org/browse/SCM-281
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-4
> Reporter: Anton Katernoga
> Assigned To: Mike Perham
> Attachments: patch.p4.txt
>
>
> I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-281) Perforce problem: incorrect client spec
is used
Posted by "Anton Katernoga (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88647 ]
Anton Katernoga commented on SCM-281:
-------------------------------------
The purpose of SCM-165 isn't very clear to me, but from the comments I see it was necessary for several commands to run with same persistent client spec. Why do you save this specname in property although you can simply re-generate it from repo and workDir each time and it will be the same name?
> Perforce problem: incorrect client spec is used
> -----------------------------------------------
>
> Key: SCM-281
> URL: http://jira.codehaus.org/browse/SCM-281
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-4
> Reporter: Anton Katernoga
> Assigned To: Mike Perham
> Attachments: patch.p4.txt
>
>
> I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Moved: (SCM-281) Perforce problem: incorrect client spec is
used
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Perham moved CONTINUUM-1183 to SCM-281:
--------------------------------------------
Affects Version/s: (was: 1.0.3)
1.0-beta-4
Component/s: (was: SCM)
maven-scm-provider-perforce
Key: SCM-281 (was: CONTINUUM-1183)
Project: Maven SCM (was: Continuum)
> Perforce problem: incorrect client spec is used
> -----------------------------------------------
>
> Key: SCM-281
> URL: http://jira.codehaus.org/browse/SCM-281
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-4
> Reporter: Anton Katernoga
> Attachments: patch.p4.txt
>
>
> I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-281) Perforce problem: incorrect client spec
is used
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated SCM-281:
-----------------------------
Patch Submitted: [Yes]
> Perforce problem: incorrect client spec is used
> -----------------------------------------------
>
> Key: SCM-281
> URL: http://jira.codehaus.org/browse/SCM-281
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-4
> Reporter: Anton Katernoga
> Assignee: Mike Perham
> Fix For: future
>
> Attachments: patch.p4.txt
>
>
> I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-281) Perforce problem: incorrect client spec
is used
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88672 ]
Mike Perham commented on SCM-281:
---------------------------------
Because some corporations have naming standards for clientspecs so the clientspec name cannot be pregenerated or determined beforehand.
> Perforce problem: incorrect client spec is used
> -----------------------------------------------
>
> Key: SCM-281
> URL: http://jira.codehaus.org/browse/SCM-281
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-4
> Reporter: Anton Katernoga
> Assigned To: Mike Perham
> Attachments: patch.p4.txt
>
>
> I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SCM-281) Perforce problem: incorrect client spec
is used
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Venisse updated SCM-281:
---------------------------------
Fix Version/s: future
> Perforce problem: incorrect client spec is used
> -----------------------------------------------
>
> Key: SCM-281
> URL: http://jira.codehaus.org/browse/SCM-281
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-4
> Reporter: Anton Katernoga
> Assigned To: Mike Perham
> Fix For: future
>
> Attachments: patch.p4.txt
>
>
> I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SCM-281) Perforce problem: incorrect client spec
is used
Posted by "Sebastian Annies (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_96364 ]
Sebastian Annies commented on SCM-281:
--------------------------------------
The client spec seems to be a major problem with the perforce integration. I propose to use the P4CONFIG mechanism (or a mechanism similar to it).
1. the perforce commands should watch out for a file named .p4clientspec (just as an example) in the directory they are working in
2. if the file exists, read it and use its content as client name.
3. if a client is created by checkout command this file has to be written
What do you think?
> Perforce problem: incorrect client spec is used
> -----------------------------------------------
>
> Key: SCM-281
> URL: http://jira.codehaus.org/browse/SCM-281
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-perforce
> Affects Versions: 1.0-beta-4
> Reporter: Anton Katernoga
> Assignee: Mike Perham
> Fix For: future
>
> Attachments: patch.p4.txt
>
>
> I have 2 projects set up which use the same perforce scm url. One is run each 5 mins, the other is a nightly tests build. I've noticed that the latter never gets run-the message is that the dir is up-to date. It appeared that after the first project is run, its client spec is set to system variable in PerforceCheckOutCommand (maven-scm perforce provider) class and afterwards the value of the var is used instead of a correct client spec. I didn't remove the property set, as it is a fix to SCM-165, but rather the place where prop is used. Now works fine.
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira