[GitHub] [spark] dbtsai commented on a change in pull request #24541: [SPARK-27646] [SQL] [WIP] Required refactoring for bytecode analysis

[GitBox <gi...@apache.org>]

dbtsai commented on a change in pull request #24541: [SPARK-27646] [SQL] [WIP] Required refactoring for bytecode analysis
URL: https://github.com/apache/spark/pull/24541#discussion_r281381105
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
 ##########
 @@ -250,58 +263,77 @@ class ScalaReflectionSuite extends SparkFunSuite {
           "nestedArrayField",
           ArrayType(ArrayType(IntegerType, containsNull = false), containsNull = true)))),
       nullable = true))
+    assert(schema1 === schema2)
   }
 
   test("generic data") {
-    val schema = schemaFor[GenericData[Int]]
-    assert(schema === Schema(
+    val d = GenericData(3)
+    val schema1 = schemaFor[GenericData[Int]]
 
 Review comment:
   @aokolnychyi this test is failing because of type erasure. To be fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org