You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/28 16:08:58 UTC
[jira] [Commented] (TINKERPOP-1534) Gremlin Server instances
leaking in tests
[ https://issues.apache.org/jira/browse/TINKERPOP-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615813#comment-15615813 ]
ASF GitHub Bot commented on TINKERPOP-1534:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/469
TINKERPOP-1534 Improve GraphProvider ability to release resources
https://issues.apache.org/jira/browse/TINKERPOP-1534
Specifically, made `AbstractGremlinSuite` attempt to `close()` a `GraphProvider` if it implemented `AutoCloseable`. Added better logging to `gremlin-python` server start/stop script. Removed `DriverRemoteConnectionTest` as it was an ignored test anyway and a remnant of the original way we tested `gremlin-python`. Implemented `AutoCloseable` on `RemoteGraphProvider` to kill Gremlin Server which is no longer started statically.
Interestingly the issue might have had less to do with "proper shutdown" and more with:
https://github.com/apache/tinkerpop/commit/30c2600bff074a7053cecab90baeccb60b087456
which was fixed on `tp31` and merged forward. Anyway, there should be no more leaking of Gremlin Server log messages into hadoop/spark/etc (i.e. anything after the gremlin server portion of the build).
Works with `mvn clean install`.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1534
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #469
----
commit 9a8c2d20ea24ed71b7b1350b9a31f27fccfb0527
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-10-28T15:55:47Z
TINKERPOP-1534 Improve GraphProvider ability to release resources
Specifically, made AbstractGremlinSuite attept to close() a GraphProvider if it implemented AutoCloseable. Added better logging to gremlin-python server start/stop script. Removed DriverRemoteConnectionTest as it was an ignored test anyway and a remnant of the original way we tested gremlin-python. Implemented AutoCloseable on RemoteGraphProvider to kill Gremlin Server which is no longer started statically.
----
> Gremlin Server instances leaking in tests
> -----------------------------------------
>
> Key: TINKERPOP-1534
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1534
> Project: TinkerPop
> Issue Type: Bug
> Components: server, test-suite
> Affects Versions: 3.2.3
> Reporter: stephen mallette
> Assignee: stephen mallette
> Fix For: 3.2.4
>
>
> Even though Gremlin Server appears to be shut down, it still produces output in tests from spark/hadoop/etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)