You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Christine Poerschke (Jira)" <ji...@apache.org> on 2020/02/18 18:08:00 UTC

[jira] [Commented] (SOLR-14267) complete solrconfig.xml removal

    [ https://issues.apache.org/jira/browse/SOLR-14267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039299#comment-17039299 ] 

Christine Poerschke commented on SOLR-14267:
--------------------------------------------

Attached patch proposes to outright remove given that the element is unused and undocumented, and the warning has been there since 3.6.0 version:
 * [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/3.6.0/solr/core/src/java/org/apache/solr/core/SolrConfig.java#L168-L169]

An alternative to outright removal would be to annotate as deprecated first and then remove from 9.0 release onwards.

> complete <query><HashDocSet> solrconfig.xml removal
> ---------------------------------------------------
>
>                 Key: SOLR-14267
>                 URL: https://issues.apache.org/jira/browse/SOLR-14267
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-14267.patch
>
>
> * The code already warns about it being deprecated:
>  ** [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.4.1/solr/core/src/java/org/apache/solr/core/SolrConfig.java#L217-L218] – and the element attributes are read but not used.
>  * There are no apparent documentation references.
>  * A number of test solrconfig.xml files still configure the value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org